Bugzilla – Attachment 13599 Details for
Bug 9078
is_holiday should honour holiday exceptions
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 9078 - fixing exceptions broke tests
Bug-9078---fixing-exceptions-broke-tests.patch (text/plain), 1.11 KB, created by
Tomás Cohen Arazi (tcohen)
on 2012-11-21 15:58:07 UTC
(
hide
)
Description:
Bug 9078 - fixing exceptions broke tests
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2012-11-21 15:58:07 UTC
Size:
1.11 KB
patch
obsolete
>From c626a1439e4b320e49391d5e92a341db0f940528 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@gmail.com> >Date: Wed, 21 Nov 2012 12:54:46 -0300 >Subject: [PATCH] Bug 9078 - fixing exceptions broke tests >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Fixing the holiday exceptions arised a problem with how the test data was constructed. >This made several tests fail. > >This patch fixes the add_holiday function. Tests should pass now. > >Sponsored-by: Universidad Nacional de Córdoba >--- > Koha/Calendar.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/Koha/Calendar.pm b/Koha/Calendar.pm >index ee63e73..90069b6 100644 >--- a/Koha/Calendar.pm >+++ b/Koha/Calendar.pm >@@ -329,9 +329,9 @@ sub clear_weekly_closed_days { > sub add_holiday { > my $self = shift; > my $new_dt = shift; >- my @dt = $self->{exception_holidays}->as_list; >+ my @dt = $self->{single_holidays}->as_list; > push @dt, $new_dt; >- $self->{exception_holidays} = >+ $self->{single_holidays} = > DateTime::Set->from_datetimes( dates => \@dt ); > > return; >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9078
:
13583
|
13588
|
13599
|
13606
|
13607
|
13621
|
13622