Bugzilla – Attachment 136122 Details for
Bug 30971
Recalls - log viewer error
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30971: (follow-up) Fix one more occurence
Bug-30971-follow-up-Fix-one-more-occurence.patch (text/plain), 1.34 KB, created by
David Nind
on 2022-06-15 19:35:08 UTC
(
hide
)
Description:
Bug 30971: (follow-up) Fix one more occurence
Filename:
MIME Type:
Creator:
David Nind
Created:
2022-06-15 19:35:08 UTC
Size:
1.34 KB
patch
obsolete
>From 0c964a33052436346455e12dfd12fe760196a18e Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Wed, 15 Jun 2022 16:18:08 -0300 >Subject: [PATCH] Bug 30971: (follow-up) Fix one more occurence > >To test: >1. Run: > $ git grep 'recall.itemnumber' >=> SUCCESS: No more occurences >2. Run: > $ git grep 'recall.biblionumber' >=> SUCCESS: No more occurences >3. Run: > $ git grep 'recall\->biblionumber' >=> SUCCESS: No more occurences >4. Run: > $ git grep 'recall\->itemnumber' >=> FAIL: One standing occurence >5. Apply this patch >6. Repeat 4 >=> SUCCESS: No more occurences >7. Sign off :-D > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> > >Signed-off-by: David Nind <david@davidnind.com> >--- > svc/checkouts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/svc/checkouts b/svc/checkouts >index c6a3e6c6f3..b8e84f4704 100755 >--- a/svc/checkouts >+++ b/svc/checkouts >@@ -221,7 +221,7 @@ while ( my $c = $sth->fetchrow_hashref() ) { > $recall = $item->check_recalls if $item->can_be_waiting_recall; > if ( defined $recall ) { > if ( $recall->item_level ) { >- if ( $recall->itemnumber == $c->{itemnumber} ) { >+ if ( $recall->item_id == $c->{itemnumber} ) { > # item-level recall on this item > $recalled = 1; > } else { >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30971
:
136118
|
136119
|
136120
|
136121
|
136122
|
136123
|
136139
|
136140
|
136141