Attachment 136152 Details for Bug 30775 – Bug 30775: Make 952w to have datepicker plugin by default

[patch] Bug 30775: Make 952w to have datepicker plugin by default

Bug-30775-Make-952w-to-have-datepicker-plugin-by-d.patch (text/plain), 1.94 KB, created by Martin Renvoize (ashimema) on 2022-06-16 11:31:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2022-06-16 11:31:58 UTC

Size: 1.94 KB

patch

obsolete

>From 2ff62576dda623ae96a527b8f45cf6126fa112b5 Mon Sep 17 00:00:00 2001
>From: Petro Vashchuk <stalkernoid@gmail.com>
>Date: Mon, 16 May 2022 17:04:18 +0300
>Subject: [PATCH] Bug 30775: Make 952w to have datepicker plugin by default
>
>This field (Price effective from) is very similar to 952d,
>but it doesn't have dateaccessioned.pl plugin by default,
>
>Apart of worse usability of this it is also allows to enter wrong
>date which will be converted in 0000-00-00 in DB and even lead to
>crashes by code in other places.
>
>So, adding this plugin not only improves usability (user can have
>datepicker) but also adds date field validation.
>
>Test plan:
>1. Head over to MARC frameworks from your administration page,
>check 952 subfield structure of your default framework structure.
>2. dateaccessioned.pl is set as a plugin for 952d by default
>but is missing from 952w.
>3. Apply the patch and reset your koha, drop db and use reset_all alias.
>4. Check frameworks structure again and ensure that datepicker plugin
>is set by default for 952w.
>5. Edit some item to ensure that datepicker works for that 952w.
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> .../marcflavour/marc21/mandatory/marc21_framework_DEFAULT.yml   | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.yml b/installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.yml
>index 5d6d289f04..f403f6e771 100644
>--- a/installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.yml
>+++ b/installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.yml
>@@ -932,7 +932,7 @@ tables:
>           tab: 10
>           authorised_value: ""
>           authtypecode: ""
>-          value_builder: ""
>+          value_builder: dateaccessioned.pl
>           isurl: 0
>           hidden: 0
>           frameworkcode: ""
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 30775: 135018 | 135461 | 136152