Attachment 136220 Details for Bug 25498 – Bug 25498: (QA follow-up) Rename virtualshelf->patron

[patch] Bug 25498: (QA follow-up) Rename virtualshelf->patron

Bug-25498-QA-follow-up-Rename-virtualshelf-patron.patch (text/plain), 1.75 KB, created by Marcel de Rooy on 2022-06-17 07:02:17 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2022-06-17 07:02:17 UTC

Size: 1.75 KB

patch

obsolete

>From 428df55056e3357d46aa8ad45ce3c5cb9a90b4f4 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Fri, 17 Jun 2022 06:58:09 +0000
>Subject: [PATCH] Bug 25498: (QA follow-up) Rename virtualshelf->patron
>Content-Type: text/plain; charset=utf-8
>
>This patron is a 'sharee' (not the sharer).
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> Koha/Virtualshelfshare.pm | 6 +++---
> opac/opac-shelves.pl      | 2 +-
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/Koha/Virtualshelfshare.pm b/Koha/Virtualshelfshare.pm
>index 16bd017351..8a9252efe2 100644
>--- a/Koha/Virtualshelfshare.pm
>+++ b/Koha/Virtualshelfshare.pm
>@@ -81,13 +81,13 @@ sub has_expired {
>     return $has_expired == 1 ? 1 : 0
> }
> 
>-=head3 patron
>+=head3 sharee
> 
>-    Returns related Koha::Patron object for this share.
>+    Returns related Koha::Patron object for the sharee (patron who got this share).
> 
> =cut
> 
>-sub patron {
>+sub sharee {
>     my $self = shift;
>     return Koha::Patron->_new_from_dbic( $self->{_result}->borrowernumber );
> }
>diff --git a/opac/opac-shelves.pl b/opac/opac-shelves.pl
>index cce27b9f05..d93ae2c52a 100755
>--- a/opac/opac-shelves.pl
>+++ b/opac/opac-shelves.pl
>@@ -272,7 +272,7 @@ if ( $op eq 'add_form' ) {
>         my $patrons = [];
>         my $shares = $shelf->get_shares->search({ borrowernumber => { '!=' => undef } });
>         while( my $share = $shares->next ) {
>-            push @$patrons, { email => $share->patron->notice_email_address, borrowernumber => $share->get_column('borrowernumber') };
>+            push @$patrons, { email => $share->sharee->notice_email_address, borrowernumber => $share->get_column('borrowernumber') };
>         }
>         $template->param( shared_users => $patrons );
>         $op = 'transfer';
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 25498: 135889 | 135921 | 136008 | 136009 | 136010 | 136011 | 136033 | 136034 | 136035 | 136036 | 136166 | 136167 | 136168 | 136169 | 136220 | 136221 | 137862 | 137863 | 137864 | 137865 | 137866 | 137867 | 137871 | 137908