Attachment 136311 Details for Bug 30989 – Bug 30989: Use uri filter where tag links are displayed

[patch] Bug 30989: Use uri filter where tag links are displayed

Bug-30989-Use-uri-filter-where-tag-links-are-displ.patch (text/plain), 4.52 KB, created by David Nind on 2022-06-17 20:58:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2022-06-17 20:58:52 UTC

Size: 4.52 KB

patch

obsolete

>From 6e79301ef6ec85dbbbf9743084bfd43e8c6238f8 Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Fri, 17 Jun 2022 19:45:42 +0000
>Subject: [PATCH] Bug 30989: Use uri filter where tag links are displayed
>
>TO test:
>1. Turn on: TagsEnabled.
>2. Log in to the OPAC and create a tag like "LGBTQ+"
>3. Add that record to a list
>3. Now try clicking on that tag from detail, results, and lists page.
>4. If you click on the link for the "LGBTQ+" you will get a 'no results found page'.
>5. Apply patch
>6. Try clicking on each of the tags in detail, results, and lists. They should work now.
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 2 +-
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt | 2 +-
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>index a62af151c9..7f49236e42 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>@@ -207,7 +207,7 @@
> Tags from this library:
> <ul id="tagslist">
> [% FOREACH TagLoo IN TagLoop %]
>- <li><a href="/cgi-bin/koha/opac-search.pl?tag=[% TagLoo.term |url %]&amp;q=[% TagLoo.term |url %]">[% TagLoo.term | html %]</a> ([% TagLoo.weight_total | html %])
>+ <li><a href="/cgi-bin/koha/opac-search.pl?tag=[% TagLoo.term | uri %]&amp;q=[% TagLoo.term | uri %]">[% TagLoo.term | html %]</a> ([% TagLoo.weight_total | html %])
> [% IF ( loop.last ) %][% ELSE %], [% END %]
> </li>
> [% END %]
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
>index 98106fdcd7..b71ad4ed86 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
>@@ -470,7 +470,7 @@
> <ul>
> [% FOREACH TagLoo IN SEARCH_RESULT.TagLoop %]
> <li>
>- <a href="/cgi-bin/koha/opac-search.pl?tag=[% TagLoo.term | url %]&amp;q=[% TagLoo.term |url %]">[% TagLoo.term | html %]</a>
>+ <a href="/cgi-bin/koha/opac-search.pl?tag=[% TagLoo.term | uri %]&amp;q=[% TagLoo.term | uri %]">[% TagLoo.term | html %]</a>
> ([% TagLoo.weight_total | html %])
> </li>
> [% END %]
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
>index b0a3b7e7d2..07f6b7b130 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
>@@ -482,7 +482,7 @@
> Tags:
> <ul>
> [% FOREACH TagLoo IN itemsloo.TagLoop %]
>- <li><a href="/cgi-bin/koha/opac-search.pl?tag=[% TagLoo.term |url %]&amp;q=[% TagLoo.term |url %]">[% TagLoo.term | html %]</a> ([% TagLoo.weight_total | html %])</li>
>+ <li><a href="/cgi-bin/koha/opac-search.pl?tag=[% TagLoo.term | uri %]&amp;q=[% TagLoo.term | uri %]">[% TagLoo.term | html %]</a> ([% TagLoo.weight_total | html %])</li>
> [% END %]
> </ul>
> </div>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 30989: 136303 | 136311 | 136313 | 136314 | 136317