Bugzilla – Attachment 136317 Details for
Bug 30989
Tags with some special characters are not encoded right
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30989:(QA follow-up) Use uri filter on OPAC tag cloud page
Bug-30989QA-follow-up-Use-uri-filter-on-OPAC-tag-c.patch (text/plain), 2.36 KB, created by
Katrin Fischer
on 2022-06-17 22:25:37 UTC
(
hide
)
Description:
Bug 30989:(QA follow-up) Use uri filter on OPAC tag cloud page
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2022-06-17 22:25:37 UTC
Size:
2.36 KB
patch
obsolete
>From e0ca38b4dfcd3a4bd967752cb5a49bc1e7f32038 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Fri, 17 Jun 2022 22:23:31 +0000 >Subject: [PATCH] Bug 30989:(QA follow-up) Use uri filter on OPAC tag cloud > page > >This fixes 2 links on the page: >* The tag within the 'all tags' cloud >* The tag shown in the 'your tags' table > >Test plan as before: Test with a tag like +++ >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt >index 445ec01a03..eb77c4ffc9 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt >@@ -116,7 +116,7 @@ > <div id="tagcloud"> > [% FOREACH TAGLOO IN TAGLOOP %] > <span class="tag tagweight[% TAGLOO.stratum | html %]" id="tag[% loop.count | html %]" style="display:inline;"> >- <a href="/cgi-bin/koha/opac-search.pl?tag=[% TAGLOO.term |url %]&q=[% TAGLOO.term |url %]">[% TAGLOO.term | html %]</a> >+ <a href="/cgi-bin/koha/opac-search.pl?tag=[% TAGLOO.term |uri %]&q=[% TAGLOO.term |uri %]">[% TAGLOO.term | html %]</a> > <span class="tagweight">[% TAGLOO.weight_total | html %]</span> > </span> > [% END %] >@@ -153,7 +153,7 @@ > <td class="tagterm"> > <span class="tdlabel">Tag:</span> > [% IF MY_TAG.approved == 1 %] >- <a href="/cgi-bin/koha/opac-search.pl?tag=[% MY_TAG.term |url %]&q=[% MY_TAG.term |url %]">[% MY_TAG.term | html %]</a> >+ <a href="/cgi-bin/koha/opac-search.pl?tag=[% MY_TAG.term |uri %]&q=[% MY_TAG.term |uri %]">[% MY_TAG.term | html %]</a> > [% ELSE %] > [% MY_TAG.term | html %] (not approved) > [% END %] >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30989
:
136303
|
136311
|
136313
|
136314
| 136317