Attachment 136335 Details for Bug 30567 – Bug 30567: Fix price formatting when adding a manual invoice with CurrencyFormat FR

[patch] Bug 30567: Fix price formatting when adding a manual invoice with CurrencyFormat FR

Bug-30567-Fix-price-formatting-when-adding-a-manua.patch (text/plain), 1.97 KB, created by David Nind on 2022-06-19 22:00:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2022-06-19 22:00:28 UTC

Size: 1.97 KB

patch

obsolete

>From 50b16036eef126b0a172add5a4325c4c100419df Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Mon, 6 Jun 2022 21:34:26 +0000
>Subject: [PATCH] Bug 30567: Fix price formatting when adding a manual invoice
> with CurrencyFormat FR
>
>In input fields we always use the decimal . while the display format
>uses the decimal separtor definded by CurrencyFormat. When adding a
>manual invoice without this patch, the amount is shown with comma, but
>it should be . in the input field.
>
>To test:
>1- Go in Administration->Debit types
>2- Click on New debit type
>3- Fill the form:
>   Code: USEDBOOK
>   Default amount: 0.50
>   Description: Used book
>   Can be manually invoiced: Yes
>4- Save
>5- Go to any patron account
>6- Go to the "Accounting" tab
>7- Click on "Create manual invoice"
>8- Fill the form
>9- Choose the created debit (Used book)
>10- Verify that the format is incorrect (0,50 instead of 0.50)
>11- Apply the patch
>12- Verify the amount is now using the correct format
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/members/maninvoice.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/maninvoice.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/maninvoice.tt
>index d059c38f72..05de80543b 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/maninvoice.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/maninvoice.tt
>@@ -111,7 +111,7 @@
>     <script>
>         var type_fees = {};
>         [% FOREACH debit_type IN debit_types %]
>-            type_fees['[% debit_type.code | html %]'] = "[% IF debit_type.default_amount %][% debit_type.default_amount | $Price %][% END %]";
>+            type_fees['[% debit_type.code | html %]'] = "[% IF debit_type.default_amount %][% debit_type.default_amount | $Price on_editing => 1 %][% END %]";
>         [% END %]
>         $(document).ready(function(){
>             $('#maninvoice').preventDoubleFormSubmit();
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 30567: 133413 | 135737 | 136335 | 137059