Attachment 136373 Details for Bug 30925 – Bug 30925: Fix category parameter for addbybiblionumber

[patch] Bug 30925: Fix category parameter for addbybiblionumber

Bug-30925-Fix-category-parameter-for-addbybiblionu.patch (text/plain), 2.92 KB, created by Tomás Cohen Arazi (tcohen) on 2022-06-20 13:35:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2022-06-20 13:35:58 UTC

Size: 2.92 KB

patch

obsolete

>From 4d0bacc2778ae8950090032be4537e1f4fec8377 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Mon, 20 Jun 2022 07:03:17 +0000
>Subject: [PATCH] Bug 30925: Fix category parameter for addbybiblionumber
>
>In bug 28959 category was replaced in favor of public. But
>unfortunately a few places were missed.
>This fixes the addbybiblionumber templates.
>
>Test plan:
>Add a biblio to a list from the search results using the Add to
>or Add to list button on OPAC/intranet.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> .../prog/en/modules/virtualshelves/addbybiblionumber.tt     | 6 +++---
> .../bootstrap/en/modules/opac-addbybiblionumber.tt          | 6 +++---
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/addbybiblionumber.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/addbybiblionumber.tt
>index 252357f6a4..785a0d43ba 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/addbybiblionumber.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/addbybiblionumber.tt
>@@ -95,9 +95,9 @@
>     </li>
>     <li>
>         <label for="category">Category:</label>
>-        <select name="category" id="category">
>-        <option value="1">Private</option>
>-        <option value="2">Public</option>
>+        <select name="public" id="public">
>+        <option value="0">Private</option>
>+        <option value="1">Public</option>
>         </select>
>     </li></ol>
>     </fieldset>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-addbybiblionumber.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-addbybiblionumber.tt
>index c79ee3d2a4..8b8cb42576 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-addbybiblionumber.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-addbybiblionumber.tt
>@@ -79,10 +79,10 @@
>                                             <label for="newvirtualshelf">List name:</label>
>                                             <input type="text" name="newvirtualshelf" id="newvirtualshelf" size="40" />
>                                             <label for="category">Category:</label>
>-                                            <select name="category" id="category">
>-                                                <option value="1">Private</option>
>+                                            <select name="public" id="public">
>+                                                <option value="0">Private</option>
>                                                 [% IF (OpacAllowPublicListCreation) %]
>-                                                    <option value="2">Public</option>
>+                                                    <option value="1">Public</option>
>                                                 [% END %]
>                                             </select>
>                                     </fieldset>
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 30925: 136337 | 136373