Bugzilla – Attachment 136400 Details for
Bug 29325
commit_file.pl error 'Already in a transaction'
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29325: Call progress callback one last time to confirm comppletion
Bug-29325-Call-progress-callback-one-last-time-to-.patch (text/plain), 1.28 KB, created by
Martin Renvoize (ashimema)
on 2022-06-21 15:28:58 UTC
(
hide
)
Description:
Bug 29325: Call progress callback one last time to confirm comppletion
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2022-06-21 15:28:58 UTC
Size:
1.28 KB
patch
obsolete
>From d1ebcf6473b770d4dd741ada9461931094f5ca16 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Wed, 1 Jun 2022 18:36:44 +0000 >Subject: [PATCH] Bug 29325: Call progress callback one last time to confirm > comppletion > >Previously after finishing the loop we were still in a transaction that never completed - we should report progress when done >one final time to commit the last records > >To test: >1 - Stage a file with > 100 records >2 - Commit file >3 - Confirm batch is imported and no records left as staged > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > C4/ImportBatch.pm | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/C4/ImportBatch.pm b/C4/ImportBatch.pm >index d8717e1b44..222bf74b27 100644 >--- a/C4/ImportBatch.pm >+++ b/C4/ImportBatch.pm >@@ -708,6 +708,7 @@ sub BatchCommitRecords { > SetImportRecordStatus($rowref->{'import_record_id'}, 'ignored'); > } > } >+ &$progress_callback($rec_num, $schema); # Make sure to commit the final chunk that didn't hit the commit threshhold > $sth->finish(); > SetImportBatchStatus($batch_id, 'imported'); > return ($num_added, $num_updated, $num_items_added, $num_items_replaced, $num_items_errored, $num_ignored); >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29325
:
126944
|
127489
|
128033
|
135556
|
135557
|
135558
|
135559
|
135560
|
136390
|
136391
|
136392
|
136393
|
136394
|
136398
|
136399
|
136400
|
136401
|
136402
|
136478
|
136479
|
136480
|
136481
|
136482
|
136496
|
136497
|
136531
|
136803