Attachment 136436 Details for Bug 31020 – Bug 31020: Fix PassItemMarcToXSLT in system preferences description

[patch] Bug 31020: Fix PassItemMarcToXSLT in system preferences description

Bug-31020-Fix-PassItemMarcToXSLT-in-system-prefere.patch (text/plain), 8.27 KB, created by David Nind on 2022-06-23 01:53:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2022-06-23 01:53:04 UTC

Size: 8.27 KB

patch

obsolete

>From 9a236f7fa56673e84fb1debcd1bf7ace24eb1f32 Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Wed, 22 Jun 2022 15:04:47 -1000
>Subject: [PATCH] Bug 31020: Fix PassItemMarcToXSLT in system preferences
> description
>
>Bug 28373 added system preference PassItemMarcToXSLT is referenced is all XSLT system preferences.
>But it only applies on results pages.
>The only use in perl code is in C4::Search :
> > $marcrecord->delete_fields( @fields ) unless C4::Context->preference('PassItemMarcToXSLT');
>
>I've tested by adding in all XSLT files :
> ITEMS <xsl:value-of select="count(marc:datafield[@tag=952])"/> 
>Number of items only appears in OPAC and staff interface results pages.
>
>In fact only search pages get MARC record from search engine, in which items datas have been embedded for indexing.
>In other pages MARC record does not embed items datas.
>
>This patch adds "MARC21 952, UNIMARC 995" to be explicit we talk about
>MARC datas not item tags build in XML recieved by XSLT.
>
>Test plan :
>1) Apply patch
>2) Search for PassItemMarcToXSLT in system preferencies
>3) Look at description of PassItemMarcToXSLT
>4) Check PassItemMarcToXSLT only apprears in OPACXSLTResultsDisplay and XSLTResultsDisplay
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> .../intranet-tmpl/prog/en/modules/admin/preferences/opac.pref | 4 ++--
> .../prog/en/modules/admin/preferences/searching.pref | 3 ++-
> .../prog/en/modules/admin/preferences/staff_interface.pref | 4 ++--
> 3 files changed, 6 insertions(+), 5 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
>index ea9e864911..555febc918 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
>@@ -90,7 +90,7 @@ OPAC:
> - 'Display lists in the OPAC using XSLT stylesheet at: '
> - pref: OPACXSLTListsDisplay
> class: file
>- - ' Options:<ul><li>Enter "<a href="#" class="set_syspref" data-syspref="OPACXSLTListsDisplay" data-value="default">default</a>" for the default stylesheet</li><li>Put a path to define an xslt file</li><li>Put a URL for an external specific stylesheet.</li><li>NOTE: The system preference <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=PassItemMarcToXSLT">PassItemMarcToXSLT</a> must be enabled if your custom stylesheet utilizes data in the item fields</li></ul>If you have multiple stylesheets for different languages the placeholder {langcode} will be replaced with current interface language.'
>+ - ' Options:<ul><li>Enter "<a href="#" class="set_syspref" data-syspref="OPACXSLTListsDisplay" data-value="default">default</a>" for the default stylesheet</li><li>Put a path to define an xslt file</li><li>Put a URL for an external specific stylesheet.</li></ul>If you have multiple stylesheets for different languages the placeholder {langcode} will be replaced with current interface language.'
> -
> - 'Display OPAC results using XSLT stylesheet at: '
> - pref: OPACXSLTResultsDisplay
>@@ -100,7 +100,7 @@ OPAC:
> - 'Display OPAC details using XSLT stylesheet at: '
> - pref: OPACXSLTDetailsDisplay
> class: file
>- - ' Options:<ul><li>Enter "<a href="#" class="set_syspref" data-syspref="OPACXSLTDetailsDisplay" data-value="default">default</a>" for the default stylesheet</li><li>Put a path to define an xslt file</li><li>Put a URL for an external specific stylesheet.</li><li>NOTE: The system preference <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=PassItemMarcToXSLT">PassItemMarcToXSLT</a> must be enabled if your custom stylesheet utilizes data in the item fields</li></ul>If you have multiple stylesheets for different languages the placeholder {langcode} will be replaced with current interface language.'
>+ - ' Options:<ul><li>Enter "<a href="#" class="set_syspref" data-syspref="OPACXSLTDetailsDisplay" data-value="default">default</a>" for the default stylesheet</li><li>Put a path to define an xslt file</li><li>Put a URL for an external specific stylesheet.</li></ul>If you have multiple stylesheets for different languages the placeholder {langcode} will be replaced with current interface language.'
> -
> - pref: OpacNoItemTypeImages
> default: 0
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref
>index 69619fd6f8..4f551cfa05 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref
>@@ -281,7 +281,8 @@ Searching:
> choices:
> 1: Do
> 0: "Don't"
>- - "make item MARC tags available to XSLT stylesheets. Default is \"Don't\", items are displayed using other methods."
>+ - "make item MARC fields (MARC21 952, UNIMARC 995) available to XSLT stylesheets for OPAC and staff interface results pages."
>+ - " Default is \"Don't\", items are displayed using other methods."
> -
> - pref: ShowHeadingUse
> choices:
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_interface.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_interface.pref
>index d9b9f46bbd..8fe46bfc79 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_interface.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_interface.pref
>@@ -76,7 +76,7 @@ Staff interface:
> - 'Display lists in the staff interface using XSLT stylesheet at: '
> - pref: XSLTListsDisplay
> class: file
>- - ' Options:<ul><li>Enter "<a href="#" class="set_syspref" data-syspref="XSLTListsDisplay" data-value="default">default</a>" for the default stylesheet</li><li>Put a path to define an xslt file</li><li>Put a URL for an external specific stylesheet.</li><li>NOTE: The system preference <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=PassItemMarcToXSLT">PassItemMarcToXSLT</a> must be enabled if your custom stylesheet utilizes data in the item fields</li></ul>If you have multiple stylesheets for different languages the placeholder {langcode} will be replaced with current interface language.'
>+ - ' Options:<ul><li>Enter "<a href="#" class="set_syspref" data-syspref="XSLTListsDisplay" data-value="default">default</a>" for the default stylesheet</li><li>Put a path to define an xslt file</li><li>Put a URL for an external specific stylesheet.</li></ul>If you have multiple stylesheets for different languages the placeholder {langcode} will be replaced with current interface language.'
> -
> - 'Display results in the staff interface using XSLT stylesheet at: '
> - pref: XSLTResultsDisplay
>@@ -86,7 +86,7 @@ Staff interface:
> - 'Display details in the staff interface using XSLT stylesheet at: '
> - pref: XSLTDetailsDisplay
> class: file
>- - ' Options:<ul><li>Enter "<a href="#" class="set_syspref" data-syspref="XSLTDetailsDisplay" data-value="default">default</a>" for the default stylesheet</li><li>Put a path to define an xslt file</li><li>Put a URL for an external specific stylesheet.</li><li>NOTE: The system preference <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=PassItemMarcToXSLT">PassItemMarcToXSLT</a> must be enabled if your custom stylesheet utilizes data in the item fields</li></ul>If you have multiple stylesheets for different languages the placeholder {langcode} will be replaced with current interface language.'
>+ - ' Options:<ul><li>Enter "<a href="#" class="set_syspref" data-syspref="XSLTDetailsDisplay" data-value="default">default</a>" for the default stylesheet</li><li>Put a path to define an xslt file</li><li>Put a URL for an external specific stylesheet.</li></ul>If you have multiple stylesheets for different languages the placeholder {langcode} will be replaced with current interface language.'
> -
> - pref: DisplayIconsXSLT
> choices:
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 31020: 136435 | 136436 | 137592