Attachment 136442 Details for Bug 23991 – Bug 23991: (QA follow-up) Fix tabbing

[patch] Bug 23991: (QA follow-up) Fix tabbing

Bug-23991-QA-follow-up-Fix-tabbing.patch (text/plain), 1.48 KB, created by Martin Renvoize (ashimema) on 2022-06-23 10:26:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2022-06-23 10:26:03 UTC

Size: 1.48 KB

patch

obsolete

>From c98254b736362735cb0c2a41c32adef042d06faf Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Thu, 23 Jun 2022 11:13:10 +0100
>Subject: [PATCH] Bug 23991: (QA follow-up) Fix tabbing
>
>It looks like during one of the many rebases we lost some of the tabn
>handling, likely due to the conversion from jquery-ui to bootstrap tabs.
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> .../intranet-tmpl/prog/en/modules/suggestion/suggestion.tt    | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>index b4cd1a4dfc..f2a10b94e2 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>@@ -716,7 +716,11 @@
>             [% END # /UNLESS notabs %]
> 
>                 [% FOREACH suggestion IN suggestions %]
>+                    [% UNLESS ( notabs ) %]
>+                    <div id="[% suggestion.suggestiontype | html %]" role="tabpanel" class="tab-pane">
>+                    [% ELSE %]
>                     <div id="[% suggestion.suggestiontype | html %]">
>+                    [% END %]
>                         <form class="update_suggestions" name="f" method="post" action="/cgi-bin/koha/suggestion/suggestion.pl#[% suggestion.suggestiontype| uri %]">
> 
>                             [% IF suggestion.suggestions.size %]
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 23991: 95172 | 115203 | 115207 | 116639 | 118454 | 119256 | 127058 | 127100 | 128071 | 128072 | 128073 | 128074 | 128075 | 129511 | 129512 | 129513 | 129523 | 130049 | 131896 | 132026 | 132169 | 132170 | 132171 | 132172 | 132173 | 132174 | 132175 | 133874 | 134922 | 136441 | 136442 | 137201