Attachment 13646 Details for Bug 8843 – Bug 8843 [3.8.x] Cannot export bibliographic records by call number

[patch] Bug 8843 [3.8.x] Cannot export bibliographic records by call number

Bug-8843-38x-Cannot-export-bibliographic-records-b.patch (text/plain), 1.35 KB, created by Jonathan Druart on 2012-11-23 13:13:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2012-11-23 13:13:03 UTC

Size: 1.35 KB

patch

obsolete

>From 373900e83bdae7ab4f08be726bb32d79122c8293 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Wed, 21 Nov 2012 15:08:45 -0500
>Subject: [PATCH] Bug 8843 [3.8.x] Cannot export bibliographic records by call
> number
>
>Reworked for 3.8.x: When building the query for exports by call
>number the script has the logic reversed. It tries to select
>records with call numbers less than the starting call number and
>greater than the ending call number. This should be reversed.
>
>To test, test an export in an unpatched system. An export by
>call number will return an empty file. After applying the patch
>an export by call number should give valid results.
>
>Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
>---
> tools/export.pl |    4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/tools/export.pl b/tools/export.pl
>index d3d8646..c7f3091 100755
>--- a/tools/export.pl
>+++ b/tools/export.pl
>@@ -102,12 +102,12 @@ if ($op eq "export") {
>     }
> 
>     if ($start_callnumber) {
>-        $query .= " AND itemcallnumber <= ? ";
>+        $query .= " AND itemcallnumber >= ? ";
>         push @sql_params, $start_callnumber;
>     }
> 
>     if ($end_callnumber) {
>-        $query .= " AND itemcallnumber >= ? ";
>+        $query .= " AND itemcallnumber <= ? ";
>         push @sql_params, $end_callnumber;
>     }
>     if ($start_accession) {
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 8843: 12592 | 12597 | 13613 | 13646