Bugzilla – Attachment 136463 Details for
Bug 24239
Let the ILL module set ad hoc hard due dates
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24239: (QA follow-up) Make dbrev idempotent
Bug-24239-QA-follow-up-Make-dbrev-idempotent.patch (text/plain), 1.53 KB, created by
Tomás Cohen Arazi (tcohen)
on 2022-06-23 18:54:23 UTC
(
hide
)
Description:
Bug 24239: (QA follow-up) Make dbrev idempotent
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2022-06-23 18:54:23 UTC
Size:
1.53 KB
patch
obsolete
>From 33e6256619bdb572ea61fddf82c7bbfcf23c8359 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Thu, 23 Jun 2022 15:50:34 -0300 >Subject: [PATCH] Bug 24239: (QA follow-up) Make dbrev idempotent > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > .../bug_24239-add_date_due_to_illrequests.pl | 15 +++++++++------ > 1 file changed, 9 insertions(+), 6 deletions(-) > >diff --git a/installer/data/mysql/atomicupdate/bug_24239-add_date_due_to_illrequests.pl b/installer/data/mysql/atomicupdate/bug_24239-add_date_due_to_illrequests.pl >index bdbbe404d3..de4f543139 100755 >--- a/installer/data/mysql/atomicupdate/bug_24239-add_date_due_to_illrequests.pl >+++ b/installer/data/mysql/atomicupdate/bug_24239-add_date_due_to_illrequests.pl >@@ -1,15 +1,18 @@ > use Modern::Perl; > > return { >- bug_number => "24239", >+ bug_number => "24239", > description => "Add due_date to illrequests", > up => sub { > my ($args) = @_; > my ($dbh, $out) = @$args{qw(dbh out)}; >- # Do you stuffs here >- $dbh->do(q{ >- ALTER TABLE `illrequests` >- ADD `due_date` datetime DEFAULT NULL AFTER `biblio_id` >- }); >+ >+ unless ( column_exists( 'illrequests', 'due_date' ) ) { >+ $dbh->do(q{ >+ ALTER TABLE `illrequests` >+ ADD COLUMN `due_date` datetime DEFAULT NULL COMMENT 'Custom date due specified by backend, leave NULL for default date_due calculation' >+ AFTER `biblio_id` >+ }); >+ } > }, > }; >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24239
:
96246
|
106409
|
130056
|
130057
|
130414
|
130415
|
130416
|
133475
|
133476
|
133477
|
135244
|
135245
|
135246
|
135943
|
135944
|
135945
|
136458
|
136459
|
136460
|
136461
|
136462
| 136463