Attachment 136471 Details for Bug 10086 – Bug 10086: No way to go back to the basket on uncertain prices page

[patch] Bug 10086: No way to go back to the basket on uncertain prices page

Bug-10086-No-way-to-go-back-to-the-basket-on-uncer.patch (text/plain), 4.14 KB, created by Michal Urban on 2022-06-24 04:30:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Michal Urban

Created: 2022-06-24 04:30:30 UTC

Size: 4.14 KB

patch

obsolete

>From 55b280efebc3ca4a2dbc086de7c0cb5078041c10 Mon Sep 17 00:00:00 2001
>From: Michal Urban <michalurban177@gmail.com>
>Date: Tue, 21 Jun 2022 05:52:58 -0400
>Subject: [PATCH] Bug 10086: No way to go back to the basket on uncertain
> prices page
>
>Fixed the edit button placement to the right-most column and fixed the
>the displayed information in the order column from calling non-existent
>variables based on the item.
>
>To test:
>1) Add an item with uncertain prices to a basket
>2) Go to the vendor of the basket
>3) Click Uncertain prices on the left
>4) Notice 'edit' button does not look like a button, and basket name is
>not a link
>5) Apply patch and refresh page
>6) Basket name is now a link. Click to confirm it takes you to the right
>page
>7) Edit button is now in edit column. Confirm it works as expected
>8) Confirm you cannot sort on Edit column and the button does not wrap
>on a narrower browser
>9) Check that the correct information is displayed for the order column
>(title, author, publisher code, publication year, copyright date, isbn)
>---
> .../prog/en/modules/acqui/uncertainprice.tt    | 18 +++++++++++++-----
> 1 file changed, 13 insertions(+), 5 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt
>index c10c1fed5e..3db3078b01 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt
>@@ -122,11 +122,11 @@ var MSG_INVALIDPRICE = _("ERROR: Price is not a valid number, please check the p
> 	    <tr>
>             <th>Basket</th>
>             <th>Order</th>
>-            <th>Edit</th>
>             <th>By</th>
>             <th>Uncertain</th>
>             <th>Price</th>
>             <th>Quantity</th>
>+            <th>Edit</th>
> 	    </tr>
>         </thead>
>         <tbody>
>@@ -136,10 +136,15 @@ var MSG_INVALIDPRICE = _("ERROR: Price is not a valid number, please check the p
>             <a href="/cgi-bin/koha/acqui/basket.pl?basketno=[% uncertainpriceorder.basketno %]">[% uncertainpriceorder.basketname %]</a>
>         </td>
>         <td>
>-            [% uncertainpriceorder.bibtitle %] / [% uncertainpriceorder.bibauthor %] <br /> [% uncertainpriceorder.bibpublishercode %], [% uncertainpriceorder.bibpublicationyear %]<br />[% uncertainpriceorder.bibisbn %]
>-        </td>
>-        <td class="actions">
>-            <a href="/cgi-bin/koha/acqui/neworderempty.pl?ordernumber=[% uncertainpriceorder.ordernumber %]&amp;booksellerid=[% booksellerid %]&amp;basketno=[% uncertainpriceorder.basketno %]" class="btn btn-default btn-xs"><i class="fa fa-pencil"></i> Edit</a>
>+            [% uncertainpriceorder.title | html %]
>+            [% IF ( uncertainpriceorder.author ) %] <em>by</em> [% uncertainpriceorder.author | html %][% END %]
>+            [% IF ( uncertainpriceorder.publishercode ) %]
>+                <br /><em>Publisher:</em> [% uncertainpriceorder.publishercode | html %]
>+                [%- IF    ( uncertainpriceorder.publicationyear ) -%], [% uncertainpriceorder.publicationyear | html %]
>+                [%- ELSIF ( uncertainpriceorder.copyrightdate ) -%] [% uncertainpriceorder.copyrightdate | html %]
>+                [% END %]
>+            [% END %]
>+            [% IF ( uncertainpriceorder.isbn ) %]<br />[% uncertainpriceorder.isbn | html %][% END %]
>         </td>
>         <td>
>             [% uncertainpriceorder.firstname | html %] [% uncertainpriceorder.surname | html %]
>@@ -158,6 +163,9 @@ var MSG_INVALIDPRICE = _("ERROR: Price is not a valid number, please check the p
>             <input class="check_uncertain" data-ordernumber="[% uncertainpriceorder.ordernumber | html %]" type="text" size="10" name="qty[% uncertainpriceorder.ordernumber | html %]" value="[% uncertainpriceorder.quantity | html %]" />
>         [% END %]
> 	    </td>
>+        <td class="actions">
>+            <a href="/cgi-bin/koha/acqui/neworderempty.pl?ordernumber=[% uncertainpriceorder.ordernumber %]&amp;booksellerid=[% booksellerid %]&amp;basketno=[% uncertainpriceorder.basketno %]" class="btn btn-default btn-xs"><i class="fa fa-pencil"></i> Edit</a>
>+        </td>
> 	    </tr>
> 	    [% END %]
>     </tbody>
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 10086: 60167 | 136471 | 136505 | 136506 | 137681 | 137737 | 138854 | 138855