Attachment 136488 Details for Bug 31039 – Bug 31039: Remove duplicate modal printing JS

[patch] Bug 31039: Remove duplicate modal printing JS

Bug-31039-Remove-duplicate-modal-printing-JS.patch (text/plain), 1.70 KB, created by Martin Renvoize (ashimema) on 2022-06-24 12:13:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2022-06-24 12:13:05 UTC

Size: 1.70 KB

patch

obsolete

>From 12c854a3d486909cf65e05beeeac74b1b1f2ff98 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Fri, 24 Jun 2022 13:10:46 +0100
>Subject: [PATCH] Bug 31039: Remove duplicate modal printing JS
>
>This patch removes the erroneos duplication of the modal printing js.
>
>Test plan
>1) Create some transactions and perform a cashup.
>2) Open the cashup summary modal
>3) Click 'Print'
>4) Cancel the print dialogue
>5) Note that the dialogue re-appears
>6) Apply the patch
>7) Repeat and note the dialogue closes first time now.
>---
> .../prog/en/modules/pos/register.tt             | 17 -----------------
> 1 file changed, 17 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt
>index b5604d8f97..1388f165f7 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt
>@@ -407,23 +407,6 @@
>             win.focus();
>         });
> 
>-        $('.modal.printable').on('shown.bs.modal', function() {
>-            $('.modal-dialog', this).addClass('focused');
>-            $('body').addClass('modalprinter');
>-
>-            if ($(this).hasClass('autoprint')) {
>-                window.print();
>-            }
>-        }).on('hidden.bs.modal', function () {
>-            $('.modal-dialog', this).removeClass('focused');
>-            $('body').removeClass('modalprinter');
>-        });
>-
>-        $('.printModal').click(function() {
>-            window.print();
>-        });
>-
>-
>         var cashups_table_url = "/api/v1/cash_registers/[% register.id | html %]/cashups?";
>         var cashups_table = $("#table_cashups").kohaTable({
>             "ajax": {
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 31039: 136488 | 136532 | 136533 | 137046 | 137367 | 137368 | 137514 | 137515