Bugzilla – Attachment 136607 Details for
Bug 30650
Add a curbside pickup module
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30650: Prevent browser crash if no pickup interval set
Bug-30650-Prevent-browser-crash-if-no-pickup-inter.patch (text/plain), 2.19 KB, created by
Jonathan Druart
on 2022-06-27 13:26:50 UTC
(
hide
)
Description:
Bug 30650: Prevent browser crash if no pickup interval set
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2022-06-27 13:26:50 UTC
Size:
2.19 KB
patch
obsolete
>From 7cb36cbd3eb4889bc9b6671276cd283ecccb169e Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 15 Jun 2022 11:27:19 +0200 >Subject: [PATCH] Bug 30650: Prevent browser crash if no pickup interval set > >Don't get stuck in an infinite loop >--- > .../intranet-tmpl/prog/en/modules/circ/curbside_pickups.tt | 4 ++++ > .../opac-tmpl/bootstrap/en/modules/opac-curbside-pickups.tt | 4 ++++ > 2 files changed, 8 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/curbside_pickups.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/curbside_pickups.tt >index 58f0767c33a..07f4e9d80b4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/curbside_pickups.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/curbside_pickups.tt >@@ -550,6 +550,10 @@ > > slots_per_day[dow].forEach(function(slot){ > let pickup_interval = policy.pickup_interval; >+ if (!pickup_interval) { >+ $('#pickup-times').html("<div>"+_("No pickup time define for this day.")+"</div>"); >+ return; >+ } > > let listStartMoment = selectedDate.hour(slot.start_hour).minute(slot.start_minute); > let listEndMoment = selectedDate.hour(slot.end_hour).minute(slot.end_minute); >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-curbside-pickups.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-curbside-pickups.tt >index 5b6fe81aea2..55852ccdc0d 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-curbside-pickups.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-curbside-pickups.tt >@@ -310,6 +310,10 @@ > > policy.slots_per_day[dow].forEach(function(slot){ > let pickup_interval = policy.pickup_interval; >+ if (!pickup_interval) { >+ $('#pickup-times').html("<div>"+_("No pickup time define for this day.")+"</div>"); >+ return; >+ } > > let listStartMoment = selectedDate.hour(slot.start_hour).minute(slot.start_minute); > let listEndMoment = selectedDate.hour(slot.end_hour).minute(slot.end_minute); >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30650
:
136584
|
136585
|
136586
|
136587
|
136588
|
136589
|
136590
|
136591
|
136592
|
136593
|
136594
|
136595
|
136596
|
136597
|
136598
|
136599
|
136600
|
136601
|
136602
|
136603
|
136604
|
136605
|
136606
|
136607
|
136608
|
136609
|
136610
|
137095
|
137100
|
137199
|
137211
|
137212
|
137277
|
137278
|
137279
|
137280
|
137281
|
137282
|
137283
|
137284
|
137285
|
137286
|
137287
|
137288
|
137289
|
137290
|
137291
|
137292
|
137293
|
137294
|
137295
|
137296
|
137297
|
137298
|
137299
|
137300
|
137301
|
137302
|
137303
|
137304
|
137305
|
137306
|
137307
|
138261
|
138262
|
138263
|
138264
|
138265
|
138266
|
138267
|
138268
|
138269
|
138270
|
138271
|
138272
|
138273
|
138274
|
138275
|
138276
|
138277
|
138278
|
138279
|
138280
|
138281
|
138282
|
138283
|
138284
|
138285
|
138286
|
138287
|
138288
|
138289
|
138290
|
138291
|
138292
|
138319
|
138320
|
138321
|
138322
|
138323
|
138324
|
138325
|
138330
|
138331
|
138332
|
138333
|
138334
|
138335
|
138336
|
138337
|
138338
|
138339
|
138340
|
138341
|
138342
|
138343
|
138344
|
138345
|
138346
|
138347
|
138348
|
138349
|
138350
|
138351
|
138352
|
138353
|
138354
|
138355
|
138356
|
138357
|
138358
|
138359
|
138360
|
138361
|
138362
|
138363
|
138364
|
138365
|
138366
|
138367
|
138368
|
138369
|
138375
|
138401
|
138610