Bugzilla – Attachment 136674 Details for
Bug 30838
to_address is misleading for SMS transports
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30838: Don't fallback through phone numbers for sms
Bug-30838-Dont-fallback-through-phone-numbers-for-.patch (text/plain), 1.09 KB, created by
Kyle M Hall (khall)
on 2022-06-28 11:27:49 UTC
(
hide
)
Description:
Bug 30838: Don't fallback through phone numbers for sms
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2022-06-28 11:27:49 UTC
Size:
1.09 KB
patch
obsolete
>From a82896f3f9779f6f9a52f0ad5eb891c8ea4c0d0b Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Tue, 24 May 2022 12:32:45 +0100 >Subject: [PATCH] Bug 30838: Don't fallback through phone numbers for sms > >This patch removes the fallback handling for smsalartnumber as the >to_address in notices. We ignore the to_address field in the message >queue at send time for sms anyway and use smsalertnumber exclusively so >having this field populated is just confusing to the end user > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > C4/Message.pm | 3 --- > 1 file changed, 3 deletions(-) > >diff --git a/C4/Message.pm b/C4/Message.pm >index 3a3216657bd..3ac8f21dc3a 100644 >--- a/C4/Message.pm >+++ b/C4/Message.pm >@@ -185,9 +185,6 @@ sub _to_address { > || $borrower->{B_email}; > } elsif ($transport eq 'sms') { > $address = $borrower->{smsalertnumber} >- || $borrower->{phone} >- || $borrower->{phonepro} >- || $borrower->{B_phone}; > } else { > warn "'$transport' is an unknown message transport."; > } >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30838
:
135298
|
135299
|
136674
|
136675
|
136676
|
137202
|
138025
|
138026
|
138027
|
138028
|
138052