Bugzilla – Attachment 136712 Details for
Bug 12758
Failure when loading or parsing XSLT stylesheets over HTTPS
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12758: Introduce Koha::XSLT::Loader
Bug-12758-Introduce-KohaXSLTLoader.patch (text/plain), 2.56 KB, created by
Marcel de Rooy
on 2022-06-29 12:18:38 UTC
(
hide
)
Description:
Bug 12758: Introduce Koha::XSLT::Loader
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2022-06-29 12:18:38 UTC
Size:
2.56 KB
patch
obsolete
>From d4730232509d8bb98e48ec761f98a88a250c47f2 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Wed, 29 Jun 2022 12:16:46 +0000 >Subject: [PATCH] Bug 12758: Introduce Koha::XSLT::Loader >Content-Type: text/plain; charset=utf-8 > >Work in progress. This is the idea for a 'solution' ;) >--- > Koha/XSLT/Loader.pm | 68 +++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 68 insertions(+) > create mode 100644 Koha/XSLT/Loader.pm > >diff --git a/Koha/XSLT/Loader.pm b/Koha/XSLT/Loader.pm >new file mode 100644 >index 0000000000..e7f16b24cb >--- /dev/null >+++ b/Koha/XSLT/Loader.pm >@@ -0,0 +1,68 @@ >+package Koha::XSLT::Loader; >+ >+# Copyright 2022 Rijksmuseum >+# >+# This file is part of Koha. >+# >+# Koha is free software; you can redistribute it and/or modify it >+# under the terms of the GNU General Public License as published by >+# the Free Software Foundation; either version 3 of the License, or >+# (at your option) any later version. >+# >+# Koha is distributed in the hope that it will be useful, but >+# WITHOUT ANY WARRANTY; without even the implied warranty of >+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >+# GNU General Public License for more details. >+# >+# You should have received a copy of the GNU General Public License >+# along with Koha; if not, see <http://www.gnu.org/licenses>. >+ >+=head1 NAME >+ >+Koha::XSLT::Loader - Helper module to resolve issues with https stylesheets >+ >+=head1 SYNOPSIS >+ >+ Koha::XSLT::Loader->load( $filename, $string ); # returns { string => $xslt_code } >+ # where the $xslt_code will no longer contain https references >+ >+=head1 DESCRIPTION >+ >+ TODO Add some nice text >+ >+=cut >+ >+use Modern::Perl; >+ >+use base qw(Class::Accessor); >+ >+=head1 METHODS >+ >+=head2 load >+ >+sub load { >+ my ( $class, $filename, $code ) = @_; >+ >+ # TODO If you got code, check for https refs. If so, get them and >+ # turn into local file references. Cache them? >+ # Always return a string here. >+ >+ # TODO If you got filename, get the code. And go back to step 1. >+ >+# my $https_code = $self->_https_workaround( $filename, $code ); >+# return $https_code || $_[1]? >+# { 'string' => $https_code // $_[1] }: { 'location' => $_[0]//'' }; >+} >+ >+ >+ >+#sub _https_workaround { # Routine added for bug 12758 (part 1) >+# my ( $self, $file, $code ) = @_; >+# return if $file!~/^https/i; >+# require LWP::UserAgent; >+# my $ua = LWP::UserAgent->new( ssl_opts => { verify_hostname => 0 } ); >+# my $resp = $ua->get( $file ); >+# return $resp->decoded_content if $resp->is_success; #undef otherwise >+#} >+ >+1; >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12758
:
31974
|
31975
|
136711
|
136712
|
136713
|
138199
|
138200
|
138201
|
140790
|
140791
|
140792
|
142768
|
142770
|
142771
|
142772
|
143504