Attachment 136741 Details for Bug 30935 – Bug 30935: Holds to pull shows wrong first patron

[patch] Bug 30935: Holds to pull shows wrong first patron

Bug-30935-Holds-to-pull-shows-wrong-first-patron.patch (text/plain), 1.56 KB, created by Shi Yao Wang on 2022-06-29 15:20:10 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Shi Yao Wang

Created: 2022-06-29 15:20:10 UTC

Size: 1.56 KB

patch

obsolete

>From 1039244ad32fbffbea82ec06ff7aaf50d57816b5 Mon Sep 17 00:00:00 2001
>From: Shi Yao Wang <shi-yao.wang@inlibro.com>
>Date: Wed, 29 Jun 2022 11:13:27 -0400
>Subject: [PATCH] Bug 30935: Holds to pull shows wrong first patron
>
>When different patrons have item level holds on the same item, Holds to
>pull shows wrong first patron.
>
>Test plan:
>1) Place a record-level hold on a biblio with an available item
>2) Check the Holds to pull page (circ/pendingreserves.pl)
>--> The biblio should appear in the list and the patron should appear in the 'First patron' column
>3) Place a second record-level hold on the same biblio
>4) Go back to the Holds to pull page
>--> The biblio is still there, but the patron in the 'First patron' column is the second patron
>5) Place a third record-level hold on the same biblio
>6) Go back to the Holds to pull page
>--> The biblio is still there, but the patron in the 'First patron' column is the third patron
>7) Apply the patch
>8) Go back to the Holds to pull page
>--> The biblio is still there and the patron in the 'First patron' column is the first patron
>---
> circ/pendingreserves.pl | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/circ/pendingreserves.pl b/circ/pendingreserves.pl
>index 1f853554b5..e0496de18e 100755
>--- a/circ/pendingreserves.pl
>+++ b/circ/pendingreserves.pl
>@@ -218,6 +218,7 @@ my $holds_biblios_map = {
>             {
>                 join    => ['itembib', 'biblio'],
>                 select  => ['me.biblionumber', 'me.reserve_id'],
>+                order_by => { -desc => 'priority' }
>             }
>         )->unblessed
>     }
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 30935: 135904 | 135905 | 136741 | 137611