Attachment 136749 Details for Bug 31066 – Bug 31066: Update javascript to use 'text_plugin' type for regex option

[patch] Bug 31066: Update javascript to use 'text_plugin' type for regex option

Bug-31066-Update-javascript-to-use-textplugin-type.patch (text/plain), 1.66 KB, created by David Nind on 2022-06-29 19:07:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2022-06-29 19:07:04 UTC

Size: 1.66 KB

patch

obsolete

>From 4a4279329c905aaf83e752720146a7ecc2af5463 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Wed, 29 Jun 2022 11:23:22 +0000
>Subject: [PATCH] Bug 31066: Update javascript to use 'text_plugin' type for
> regex option
>
>To test:
> 1 - Confirm 952$o is not linked to a plugin in the default marc framework
> 2 - Send some tiems to batch modification
> 3 - Confirm you can select RegEx as an option for callnumber during modification
> 4 - Link 952$o to the cn_browser.pl plugin
> 5 - Repeat batch modification
> 6 - Note there is no regex option
> 7 - Apply patch
> 8 - Confirm there is a regex option
> 9 - Unlink 952$o from plugin
>10 - Confirm you still have a regex option in batch modification
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc
>index a991f0ce50..97b64abd0a 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc
>@@ -187,7 +187,7 @@
>                     [% END %]
> 
>                     [% IF add_regex %]
>-                        [% IF (mv.type == 'text' || mv.type == 'text2' || mv.type == 'textarea' ) %]
>+                        [% IF (mv.type == 'text' || mv.type == 'text_plugin' || mv.type == 'textarea' ) %]
>                             <a href="#" name="[% kohafield | html %]_field_regex" class="field_regex" id="[% subfield.id | html %]" >RegEx</a>
>                         [% END %]
>                     [% END %]
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 31066: 136710 | 136749 | 137044