Attachment 136753 Details for Bug 26311 – Bug 26311: (follow-up) Fix undefined values in sprintf

[patch] Bug 26311: (follow-up) Fix undefined values in sprintf

Bug-26311-follow-up-Fix-undefined-values-in-sprint.patch (text/plain), 1.61 KB, created by David Nind on 2022-06-29 20:48:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2022-06-29 20:48:25 UTC

Size: 1.61 KB

patch

obsolete

>From 4ef49fcb5026ce0082849b5ec3f2fdce99a9fe35 Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Mon, 27 Jun 2022 20:08:33 -1000
>Subject: [PATCH] Bug 26311: (follow-up) Fix undefined values in sprintf
>
>Avoid warns 'Use of uninitialized value in sprintf' by using
>'0' if lower age is undefined
>'unlimited' if upper are is undefined
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> misc/maintenance/search_for_data_inconsistencies.pl | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/misc/maintenance/search_for_data_inconsistencies.pl b/misc/maintenance/search_for_data_inconsistencies.pl
>index f76b66fc9d..38bc5f643b 100755
>--- a/misc/maintenance/search_for_data_inconsistencies.pl
>+++ b/misc/maintenance/search_for_data_inconsistencies.pl
>@@ -302,9 +302,9 @@ use C4::Biblio qw( GetMarcFromKohaField );
>         foreach my $invalid_patron (@invalid_patrons) {
>             my $category = $invalid_patron->category;
>             new_item(
>-                sprintf "Patron borrowernumber=%s has an invalid age of %s for their category '%s' (%s-%s)",
>+                sprintf "Patron borrowernumber=%s has an invalid age of %s for their category '%s' (%s to %s)",
>                 $invalid_patron->borrowernumber, $invalid_patron->get_age, $category->categorycode,
>-                $category->dateofbirthrequired,  $category->upperagelimit
>+                $category->dateofbirthrequired // '0',  $category->upperagelimit // 'unlimited'
>             );
>         }
>         new_hint("You may change the patron's category automatically with misc/cronjobs/update_patrons_category.pl");
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 26311: 109239 | 110106 | 110130 | 110131 | 110978 | 110979 | 110980 | 110998 | 128235 | 128236 | 128237 | 131295 | 131296 | 131297 | 132978 | 136665 | 136666 | 136667 | 136668 | 136750 | 136751 | 136752 | 136753 | 137039 | 137040 | 137041 | 137042 | 137043