Attachment 136771 Details for Bug 30268 – Bug 30268: Check mandatory fields in addorderiso2709.pl

[patch] Bug 30268: Check mandatory fields in addorderiso2709.pl

Bug-30268-Check-mandatory-fields-in-addorderiso270.patch (text/plain), 2.58 KB, created by Biblibre Sandboxes on 2022-06-30 13:47:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Biblibre Sandboxes

Created: 2022-06-30 13:47:39 UTC

Size: 2.58 KB

patch

obsolete

>From c2d244bd990e382663175db4d63d0e29a3288d11 Mon Sep 17 00:00:00 2001
>From: Julian Maurice <julian.maurice@biblibre.com>
>Date: Wed, 9 Mar 2022 16:42:50 +0100
>Subject: [PATCH] Bug 30268: Check mandatory fields in addorderiso2709.pl
>
>Test plan:
>1. Make sure you have mandatory item subfields in the MARC bibliographic
>   framework used in acquisitions ("ACQ" if it exists, the default framework
>   otherwise).
>2. Use the "Stage MARC records for import" tool to upload a file. Do not import
>   the bibliographic records.
>3. Create a new acquisition basket ("Create items when:" must be set to
>   "placing an order") and add a new order from a staged file
>4. Select the file you just uploaded
>5. In the "Items information" tab, make sure at least one mandatory subfield is
>   empty
>6. Try to submit the form. If there are errors about other mandatory fields
>   (like the fund for instance), fix those errors and resubmit. There should be
>   an error message about mandatory item subfields.
>7. Enter a value for the mandatory item subfields and resubmit the form. Verify
>   that the order and the item have been correctly created.
>
>Signed-off-by: Thibault Kero <thibault.keromnes@univ-paris8.fr>
>---
> .../prog/en/modules/acqui/addorderiso2709.tt              | 1 +
> koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js        | 8 ++++++++
> 2 files changed, 9 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt
>index 2e4421ef38..9b2f5f9043 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt
>@@ -17,6 +17,7 @@
> [% INCLUDE 'datatables.inc' %]
> [% Asset.js("js/acq.js") | $raw %]
> [% Asset.js("js/funds_sorts.js") | $raw %]
>+[% Asset.js("js/cataloging.js") | $raw %]
> [% Asset.js("js/addorderiso2709.js") | $raw %]
> [% INCLUDE 'calendar.inc' %]
> </head>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js b/koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js
>index 861c0db3a3..a499d79ba3 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js
>@@ -71,6 +71,14 @@ $(document).ready(function() {
>             return false;
>         }
> 
>+        if (0 < CheckMandatorySubfields(this.form)) {
>+            // Open the item tab
>+            $('#tabs').tabs('option', 'active', 1);
>+
>+            alert(__('Some required item subfields are not set'));
>+            return false;
>+        }
>+
>         disableUnchecked($(this.form));
> 
>         $(this.form).submit();
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 30268: 131557 | 136771 | 137703