Attachment 136791 Details for Bug 30889 – Bug 30889: Add comment for the new DB field

[patch] Bug 30889: Add comment for the new DB field

Bug-30889-Add-comment-for-the-new-DB-field.patch (text/plain), 2.31 KB, created by Tomás Cohen Arazi (tcohen) on 2022-06-30 14:57:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2022-06-30 14:57:32 UTC

Size: 2.31 KB

patch

obsolete

>From 87862615e7f06a531baade1c8188f933c2f00f11 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Thu, 30 Jun 2022 11:52:52 -0300
>Subject: [PATCH] Bug 30889: Add comment for the new DB field
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> installer/data/mysql/atomicupdate/bug_30889.pl | 10 +++++++---
> installer/data/mysql/kohastructure.sql         |  2 +-
> 2 files changed, 8 insertions(+), 4 deletions(-)
>
>diff --git a/installer/data/mysql/atomicupdate/bug_30889.pl b/installer/data/mysql/atomicupdate/bug_30889.pl
>index d58a352f9c..5a5141dc51 100755
>--- a/installer/data/mysql/atomicupdate/bug_30889.pl
>+++ b/installer/data/mysql/atomicupdate/bug_30889.pl
>@@ -2,14 +2,18 @@ use Modern::Perl;
> 
> return {
>     bug_number => "30889",
>-    description => "Add context to background_jobs",
>+    description => "Add calling context information to background_jobs",
>     up => sub {
>         my ($args) = @_;
>         my ($dbh, $out) = @$args{qw(dbh out)};
> 
>         unless( column_exists( 'background_jobs', 'context') ) {
>-            $dbh->do(q{ ALTER TABLE background_jobs ADD `context` longtext COLLATE utf8mb4_unicode_ci DEFAULT NULL AFTER `data` });
>-            say $out "field added";
>+            $dbh->do(q{
>+                ALTER TABLE background_jobs
>+                    ADD `context` longtext COLLATE utf8mb4_unicode_ci DEFAULT NULL
>+                    COMMENT 'JSON-serialized context information for the job'
>+                    AFTER `data`
>+            });
>         }
>     },
> };
>diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql
>index eee3fe4a8f..c1b20477dd 100644
>--- a/installer/data/mysql/kohastructure.sql
>+++ b/installer/data/mysql/kohastructure.sql
>@@ -984,7 +984,7 @@ CREATE TABLE `background_jobs` (
>   `type` varchar(64) COLLATE utf8mb4_unicode_ci DEFAULT NULL,
>   `queue` varchar(191) COLLATE utf8mb4_unicode_ci NOT NULL DEFAULT 'default' COMMENT 'Name of the queue the job is sent to',
>   `data` longtext COLLATE utf8mb4_unicode_ci DEFAULT NULL,
>-  `context` longtext COLLATE utf8mb4_unicode_ci DEFAULT NULL,
>+  `context` longtext COLLATE utf8mb4_unicode_ci DEFAULT NULL COMMENT 'JSON-serialized context information for the job',
>   `enqueued_on` datetime DEFAULT NULL,
>   `started_on` datetime DEFAULT NULL,
>   `ended_on` datetime DEFAULT NULL,
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 30889: 135759 | 135760 | 135932 | 135933 | 135934 | 135935 | 135936 | 136294 | 136295 | 136296 | 136297 | 136298 | 136299 | 136375 | 136376 | 136784 | 136785 | 136786 | 136787 | 136788 | 136789 | 136790 | 136791 | 136792 | 136904 | 136948