Attachment 13681 Details for Bug 9147 – Proposed patch (rebased master)

[patch] Proposed patch (rebased master)

0001-Bug-9147-OPAC-hidden-fields-are-not-hidden-in-ISBD-v.patch (text/plain), 1.66 KB, created by Fridolin Somers on 2012-11-26 14:21:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Fridolin Somers

Created: 2012-11-26 14:21:38 UTC

Size: 1.66 KB

patch

obsolete

>From f5c3f1be68b8378687f3a5591819fbaa8e2084e3 Mon Sep 17 00:00:00 2001
>From: Fridolyn SOMERS <fridolyn.somers@biblibre.com>
>Date: Mon, 26 Nov 2012 15:15:18 +0100
>Subject: [PATCH] Bug 9147: OPAC hidden fields are not hidden in ISBD view
>
>---
> C4/Biblio.pm |    8 ++++++++
> 1 file changed, 8 insertions(+)
>
>diff --git a/C4/Biblio.pm b/C4/Biblio.pm
>index 832da69..b028192 100644
>--- a/C4/Biblio.pm
>+++ b/C4/Biblio.pm
>@@ -955,6 +955,10 @@ sub GetISBDView {
>             #         warn "ERROR IN ISBD DEFINITION at : $isbdfield" unless $fieldvalue;
>             #             warn "FV : $fieldvalue";
>             if ( $subfvalue ne "" ) {
>+                # OPAC hidden subfield
>+                next
>+                  if ( ( $template eq 'opac' )
>+                    && ( $tagslib->{$fieldvalue}->{$subfvalue}->{'hidden'} || 0 ) > 0 );
>                 foreach my $field (@fieldslist) {
>                     foreach my $subfield ( $field->subfield($subfvalue) ) {
>                         my $calculated = $analysestring;
>@@ -990,6 +994,10 @@ sub GetISBDView {
>                         for my $i ( 0 .. $#subf ) {
>                             my $valuecode     = $subf[$i][1];
>                             my $subfieldcode  = $subf[$i][0];
>+                            # OPAC hidden subfield
>+                            next
>+                              if ( ( $template eq 'opac' )
>+                                && ( $tagslib->{$fieldvalue}->{$subfieldcode}->{'hidden'} || 0 ) > 0 );
>                             my $subfieldvalue = GetAuthorisedValueDesc( $tag, $subf[$i][0], $subf[$i][1], '', $tagslib );
>                             my $tagsubf       = $tag . $subfieldcode;
> 
>-- 
>1.7.9.5
>

Actions: View | Diff | Splinter Review

Attachments on bug 9147: 13680 | 13681 | 13961 | 14619