Attachment 137040 Details for Bug 26311 – Bug 26311: (QA follow-up) Rephrase output message

[patch] Bug 26311: (QA follow-up) Rephrase output message

Bug-26311-QA-follow-up-Rephrase-output-message.patch (text/plain), 1.82 KB, created by Katrin Fischer on 2022-07-02 22:02:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2022-07-02 22:02:00 UTC

Size: 1.82 KB

patch

obsolete

>From d8416bc2f4eabf33febe868d3b61101d307a83bc Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Mon, 14 Sep 2020 07:07:01 +0000
>Subject: [PATCH] Bug 26311: (QA follow-up) Rephrase output message
>
>This is a suggestion for rephrasing the message slightly:
>
>Before:
>* Patron borrowernumber=15 in category 'J' has invalid age '56'
>
>After:
>* Patron borrowernumber=37 has an invalid age of 37 for their category 'K'
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> misc/maintenance/search_for_data_inconsistencies.pl | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/misc/maintenance/search_for_data_inconsistencies.pl b/misc/maintenance/search_for_data_inconsistencies.pl
>index e64758d1e2..00f5832322 100755
>--- a/misc/maintenance/search_for_data_inconsistencies.pl
>+++ b/misc/maintenance/search_for_data_inconsistencies.pl
>@@ -286,10 +286,10 @@ use C4::Biblio qw( GetMarcFromKohaField );
>     if (@invalid_patrons) {
>         new_section("Patrons with invalid age for category");
>         foreach my $patron (@invalid_patrons) {
>-            new_item( sprintf "Patron borrowernumber=%s in category '%s' has invalid age '%s'",
>-                $patron->borrowernumber, $patron->category->categorycode, $patron->get_age );
>+            new_item( sprintf "Patron borrowernumber=%s has an invalid age of %s for their category '%s'",
>+                $patron->borrowernumber, $patron->get_age, $patron->category->categorycode, );
>         }
>-        new_hint("You may change patron's category automatically with misc/cronjobs/update_patrons_category.pl");
>+        new_hint("You may change the patron's category automatically with misc/cronjobs/update_patrons_category.pl");
>     }
> }
> 
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 26311: 109239 | 110106 | 110130 | 110131 | 110978 | 110979 | 110980 | 110998 | 128235 | 128236 | 128237 | 131295 | 131296 | 131297 | 132978 | 136665 | 136666 | 136667 | 136668 | 136750 | 136751 | 136752 | 136753 | 137039 | 137040 | 137041 | 137042 | 137043