Bugzilla – Attachment 137061 Details for
Bug 15348
Change/Edit estimated delivery date per order line
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15348: (QA follow-up) Fix useless use of proviate variable in void context
Bug-15348-QA-follow-up-Fix-useless-use-of-proviate.patch (text/plain), 1.01 KB, created by
Katrin Fischer
on 2022-07-04 13:09:09 UTC
(
hide
)
Description:
Bug 15348: (QA follow-up) Fix useless use of proviate variable in void context
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2022-07-04 13:09:09 UTC
Size:
1.01 KB
patch
obsolete
>From 3ab639f23b1c554ab7cc35c7a14d38f8e5ddd48f Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer@bsz-bw.de> >Date: Mon, 4 Jul 2022 13:05:45 +0000 >Subject: [PATCH] Bug 15348: (QA follow-up) Fix useless use of proviate > variable in void context > > FAIL acqui/moddeliverydate.pl > FAIL valid > Useless use of private variable in void context >--- > acqui/moddeliverydate.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/acqui/moddeliverydate.pl b/acqui/moddeliverydate.pl >index 239a0fc43e..e2dcf6b4eb 100755 >--- a/acqui/moddeliverydate.pl >+++ b/acqui/moddeliverydate.pl >@@ -54,7 +54,7 @@ my $order = GetOrder($ordernumber); > my $basket = GetBasket($order->{basketno}); > my $bookseller = Koha::Acquisition::Booksellers->find( $basket->{booksellerid} ); > >-if($op and $op eq 'save') { >+if($op && $op eq 'save') { > my $estimated_delivery_date = $input->param('estimated_delivery_date'); > $order->{'estimated_delivery_date'} = dt_from_string( $estimated_delivery_date ); > ModOrder($order); >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15348
:
114430
|
114583
|
114623
|
115121
|
115122
|
115123
|
115124
|
116517
|
118788
|
118789
|
119297
|
119298
|
119299
|
120653
|
120654
|
120655
|
120656
|
136560
|
136561
|
136562
|
136563
|
137057
|
137058
|
137061
|
137098
|
137099
|
137740
|
137741
|
137742
|
137743
|
138110
|
138491
|
138529
|
138530
|
138531
|
138532
|
138533
|
138534
|
138535
|
138536
|
138537
|
138538
|
138539
|
138540
|
139245
|
139274
|
139301
|
139329
|
139330
|
139331
|
139332
|
139333
|
139334
|
139335
|
139336
|
139337
|
139338
|
139339
|
139340
|
139341
|
139342
|
139343
|
139351
|
139352
|
139353
|
139354
|
139355
|
139356
|
139357
|
139358
|
139359
|
139360
|
139361
|
139362
|
139363
|
139364
|
139365
|
139831
|
139832
|
139833
|
139834
|
139835
|
139836
|
139837
|
139838
|
139839
|
139840
|
139841
|
139842
|
139843
|
139844
|
139845
|
140708
|
140735
|
143896
|
143900
|
143903
|
143904