Attachment 137201 Details for Bug 23991 – Bug 23991: Don't display empty div if no suggestions exist

[patch] Bug 23991: Don't display empty div if no suggestions exist

Bug-23991-Dont-display-empty-div-if-no-suggestions.patch (text/plain), 1.90 KB, created by Jonathan Druart on 2022-07-06 09:31:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2022-07-06 09:31:32 UTC

Size: 1.90 KB

patch

obsolete

>From f92aab200e25a5cd1a13d3fbdf2f53817a9295aa Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 6 Jul 2022 11:30:13 +0200
>Subject: [PATCH] Bug 23991: Don't display empty div if no suggestions exist
>
>If no suggestions exist we should not display an empty tab div
>---
> .../intranet-tmpl/prog/en/modules/suggestion/suggestion.tt  | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>index f2a10b94e27..1e266d58555 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>@@ -684,7 +684,7 @@
>                 </div> 
>             [% END # /FOR m %]
> 
>-            [% UNLESS ( notabs ) %]
>+            [% IF suggestions.size && !notabs %]
>                 <div id="suggestiontabs" class="toptabs">
>                     <ul class="nav nav-tabs" role="tablist">
>                         [% FOREACH suggestion IN suggestions %]
>@@ -713,7 +713,7 @@
>                         [% END # /FOREACH suggestion %]
>                     </ul> 
>                     <div class="tab-content">
>-            [% END # /UNLESS notabs %]
>+                [% END # IF suggestions.size && !notabs %]
> 
>                 [% FOREACH suggestion IN suggestions %]
>                     [% UNLESS ( notabs ) %]
>@@ -975,7 +975,7 @@
>                         </form> 
>                     </div> 
>                 [% END # /FOREACH suggestion %]
>-            [% UNLESS ( notabs ) %]
>+            [% IF suggestions.size && !notabs %]
>                     </div> 
>                 </div> 
>             [% END # /UNLESS notabs %]
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 23991: 95172 | 115203 | 115207 | 116639 | 118454 | 119256 | 127058 | 127100 | 128071 | 128072 | 128073 | 128074 | 128075 | 129511 | 129512 | 129513 | 129523 | 130049 | 131896 | 132026 | 132169 | 132170 | 132171 | 132172 | 132173 | 132174 | 132175 | 133874 | 134922 | 136441 | 136442 | 137201