Attachment 13721 Details for Bug 9137 – [SIGNED-OFF] Bug 9137 - Focus when editing/adding new itemtypes/authorised values

[patch] [SIGNED-OFF] Bug 9137 - Focus when editing/adding new itemtypes/authorised values

SIGNED-OFF-Bug-9137---Focus-when-editingadding-new.patch (text/plain), 4.07 KB, created by Katrin Fischer on 2012-11-28 06:52:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2012-11-28 06:52:21 UTC

Size: 4.07 KB

patch

obsolete

>From af2a2c0615f5992d4775f52a608249d68d28f0e7 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Mon, 26 Nov 2012 10:49:22 -0500
>Subject: [PATCH] [SIGNED-OFF] Bug 9137 - Focus when editing/adding new
> itemtypes/authorised values
>
>This patch adds the "focus" class to the relevant inputs so
>that the global staff client JS will move the focus to those fields.
>Logic in the authorised_values template puts the focus on the
>correct field whether you're adding a new category, a new value,
>or performing an edit.
>
>To test, try the following operations:
> - add an itemtype
> - edit an itemtype
> - add an authorised value category
> - add an authorised value value
> - edit an authorised value value
>
>In all cases the focus should automatically be in the first
>form field.
>
>Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com>
>Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
>All tests pass and works nicely.
>---
> .../prog/en/modules/admin/authorised_values.tt     |    6 +++++-
> .../prog/en/modules/admin/itemtypes.tt             |    8 ++++++--
> 2 files changed, 11 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt
>index 4acaac3..8657ec8 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt
>@@ -60,7 +60,7 @@
>         <fieldset class="rows"><ol>
>         <li>
> 			 [% IF ( action_add_category ) %]<label for="category">Category</label>
>-		<input type="text" name="category"  id="category" size="10" maxlength="10" />
>+            <input type="text" name="category"  id="category" size="10" maxlength="10" class="focus" />
> 			 [% ELSE %]<span class="label">Category</span>
> 		<input type="hidden" name="category" value="[% category %]" />	 [% category %]
> 			 [% END %]
>@@ -68,7 +68,11 @@
>         <li>
>             <label for="authorised_value">Authorized value</label>
>      [% IF ( action_modify ) %]<input type="hidden" id="id" name="id" value="[% id %]" />[% END %]
>+            [% IF ( action_add_category ) %]
>             <input type="text" id="authorised_value" name="authorised_value" value="[% authorised_value %]" maxlength="80" />
>+            [% ELSE %]
>+            <input type="text" id="authorised_value" name="authorised_value" value="[% authorised_value %]" maxlength="80" class="focus" />
>+            [% END %]
>         </li>
>         <li>
>             <label for="lib">Description</label>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt
>index cb3f9ba..30a3a85 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt
>@@ -168,11 +168,15 @@ Item types administration
>      </li>
>   [% ELSE %]
>       <li>
>-          <label for="itemtype">Item type</label> <input type="text" id="itemtype" name="itemtype" size="10" maxlength="10" onblur="toUC(this)" />
>+          <label for="itemtype">Item type</label> <input type="text" id="itemtype" name="itemtype" size="10" maxlength="10" onblur="toUC(this)" class="focus" />
>       </li>
>   [% END %]
>       <li>
>-          <label for="description">Description</label><input type="text" id="description" name="description" size="48" value="[% description |html %]" />      </li>
>+      [% IF ( itemtype ) %]
>+          <label for="description">Description</label><input type="text" id="description" name="description" size="48" value="[% description |html %]" class="focus" /></li>
>+      [% ELSE %]
>+          <label for="description">Description</label><input type="text" id="description" name="description" size="48" value="[% description |html %]" /></li>
>+      [% END %]
>      [% IF ( noItemTypeImages ) %]
> 	 <li><span class="label">Image: </span>Item type images are disabled. To enable them, turn off the <a href="/cgi-bin/koha/admin/preferences.pl?op=search&amp;searchfield=noItemTypeImages">noItemTypeImages system preference</a></li></ol>
> 	 [% ELSE %]</ol>
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 9137: 13685 | 13695 | 13721