Bugzilla – Attachment 137256 Details for
Bug 31086
Do not allow hold requests with no branchcode
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31086: Prevent placing hold with no pickup location
Bug-31086-Prevent-placing-hold-with-no-pickup-loca.patch (text/plain), 1.48 KB, created by
David Nind
on 2022-07-07 10:36:42 UTC
(
hide
)
Description:
Bug 31086: Prevent placing hold with no pickup location
Filename:
MIME Type:
Creator:
David Nind
Created:
2022-07-07 10:36:42 UTC
Size:
1.48 KB
patch
obsolete
>From 3e629f46fb99b80b86d6ac8414cab8f3bb00f2c3 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 1 Jul 2022 14:46:26 +0000 >Subject: [PATCH] Bug 31086: Prevent placing hold with no pickup location > >To test: >1 - Apply patch >2 - Repeat test on previous patch >3 - You should get a warning popup when attempting to save hold >4 - Reload page >5 - Inspect the HTML and manualy set #pickup value of selected option to "" >6 - Attempt to save hold >7 - You get the popup >8 - Place a hold normally (with location) and verify it works > >Signed-off-by: David Nind <david@davidnind.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 5 +++++ > 1 file changed, 5 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index 9e62356d58..2768d36af0 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -1440,8 +1440,13 @@ > else { > msg = (_("- Please select an item to place a hold") + "\n"); > } >+ } else { >+ if( $("#pickup").length < 1 || $("#pickup").val() == "" ){ >+ msg = _("- Please select a pickup location for this hold" + "\n"); >+ } > } > >+ > if (msg == "") { > $('#hold-request-form').preventDoubleFormSubmit(); > return(true); >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31086
:
136983
|
136984
|
136986
|
136987
|
137026
|
137254
|
137255
|
137256
|
137257
|
137258
|
137635
|
137636
|
137637
|
137638
|
137639
|
137640
|
137641
|
137642
|
138006
|
138018
|
138051
|
144824