Attachment 137271 Details for Bug 29051 – Bug 29051: Enable seen renewal in the staff client

[patch] Bug 29051: Enable seen renewal in the staff client

Bug-29051-Enable-seen-renewal-in-the-staff-client.patch (text/plain), 2.40 KB, created by Kyle M Hall (khall) on 2022-07-07 12:31:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2022-07-07 12:31:14 UTC

Size: 2.40 KB

patch

obsolete

>From 964b3d52557bc792463ef197e533b3ee23ac2c92 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Wed, 11 May 2022 16:13:23 +0100
>Subject: [PATCH] Bug 29051: Enable seen renewal in the staff client
>
>This patch updates the javascript for the checkouts table to add the
>checkbox back in for the case where too_unseen is the error returned by
>CanBookBeRenewed, allowing such issues to be renewed.
>
>Signed-off-by: Caroline <caroline.cyr-la-rose@inlibro.com>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js
>index 965aec6cf03..6b005bdaf11 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js
>@@ -487,11 +487,9 @@ $(document).ready(function() {
> span_style = "display: none";
> span_class = "renewals-allowed";
> } else if ( oObj.can_renew_error == "too_unseen" ) {
>- msg += ""
>+ msg += ""
> + __("Must be renewed at the library")
> + "";
>-
>- span_style = "display: none";
> span_class = "renewals-allowed";
> } else if ( oObj.can_renew_error == "restriction" ) {
> msg += ""
>@@ -570,7 +568,7 @@ $(document).ready(function() {
> var can_force_renew = ( oObj.onsite_checkout == 0 ) &&
> ( oObj.can_renew_error != "on_reserve" || (oObj.can_renew_error == "on_reserve" && AllowRenewalOnHoldOverride))
> ? true : false;
>- var can_renew = ( oObj.renewals_remaining > 0 && !oObj.can_renew_error );
>+ var can_renew = ( oObj.renewals_remaining > 0 && ( !oObj.can_renew_error || oObj.can_renew_error == "too_unseen" ));
> content += "";
> if ( can_renew || can_force_renew ) {
> content += "" + oObj.renewals_count + "";
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 29051: 134898 | 134899 | 136780 | 136782 | 137271 | 137272