Attachment 137272 Details for Bug 29051 – Bug 29051: Update svc api to allow seen renewals

[patch] Bug 29051: Update svc api to allow seen renewals

Bug-29051-Update-svc-api-to-allow-seen-renewals.patch (text/plain), 1.24 KB, created by Kyle M Hall (khall) on 2022-07-07 12:33:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2022-07-07 12:33:23 UTC

Size: 1.24 KB

patch

obsolete

>From 47c98faaf24b73e6165c87fd0d6855068fa9711e Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Wed, 11 May 2022 16:21:48 +0100
>Subject: [PATCH] Bug 29051: Update svc api to allow seen renewals
>
>This patch updates the svc/renew api endpoint to allow seen renewals
>when appropriate
>
>Signed-off-by: Caroline <caroline.cyr-la-rose@inlibro.com>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> svc/renew | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/svc/renew b/svc/renew
>index 91f79580317..470c02e7969 100755
>--- a/svc/renew
>+++ b/svc/renew
>@@ -67,10 +67,12 @@ if ( $data->{error} && $data->{error} eq 'on_reserve' && C4::Context->preference
>     $data->{error} = undef;
> }
> 
>-if ( $data->{renew_okay} ) {
>+if ( $data->{renew_okay} || ( $seen && $data->{error} eq 'too_unseen') ) {
>     try{
>         $date_due = AddRenewal( $borrowernumber, $itemnumber, $branchcode, $date_due, undef, undef, $seen );
>         $data->{date_due} = output_pref( { dt => $date_due, as_due_date => 1 } );
>+        $data->{renew_okay} = 1;
>+        $data->{error} = undef;
>     } catch {
>         if ( ref($_) eq 'Koha::Exceptions::Checkout::FailedRenewal' ) {
>             $data->{error} = 'renewal_failed';
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 29051: 134898 | 134899 | 136780 | 136782 | 137271 | 137272