Attachment 137350 Details for Bug 29050 – Bug 29050: Added a punctuation between renewal messages

[patch] Bug 29050: Added a punctuation between renewal messages

Bug-29050-Added-a-punctuation-between-renewal-mess.patch (text/plain), 1.77 KB, created by Chris Cormack on 2022-07-07 23:41:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Cormack

Created: 2022-07-07 23:41:27 UTC

Size: 1.77 KB

patch

obsolete

>From 5ac925655a93cd20ce193afdd61b61db3761a09f Mon Sep 17 00:00:00 2001
>From: Nisha Dahya <nishadahya@catalyst.net.nz>
>Date: Thu, 7 Jul 2022 23:31:38 +0000
>Subject: [PATCH] Bug 29050: Added a punctuation between renewal messages
>
>Test plan:
>
>1. First step is to go to administration > then system preferences
>2. Set unseenrenewal to "allow"
>3. Go to administatrion > circulation and fines rule
>4. Set unseenrenewals count to any number
>5. Check out an item to a patron and go to the checkouts tab
>6. Renew the item
>7. Notice that the renewal messages have no seperation
>8. Apply the patch
>9. Notice there is now a "&" in the spacing between renewal messages
>
>Sponsored-by: Catalyst IT
>Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
>---
> koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js
>index 965aec6cf0..a40190e49e 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js
>@@ -590,7 +590,7 @@ $(document).ready(function() {
>                             content += "<span class='renewals-info'>(";
>                             content += __("%s of %s renewals remaining").format(oObj.renewals_remaining, oObj.renewals_allowed);
>                             if (UnseenRenewals && oObj.unseen_allowed) {
>-                                content += __("%s of %s unseen renewals remaining").format(oObj.unseen_remaining, oObj.unseen_allowed);
>+                                content += __(" & %s of %s unseen renewals remaining").format(oObj.unseen_remaining, oObj.unseen_allowed);
>                             }
>                             content += ")</span>";
>                         }
>-- 
>2.17.1

Actions: View | Diff | Splinter Review

Attachments on bug 29050: 137348 | 137350 | 137385 | 137403