Attachment 137399 Details for Bug 28787 – Bug 28787: Comment selenium test that will fail if no SMTP server is defined

[patch] Bug 28787: Comment selenium test that will fail if no SMTP server is defined

Bug-28787-Comment-selenium-test-that-will-fail-if-.patch (text/plain), 2.16 KB, created by Marcel de Rooy on 2022-07-08 09:44:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2022-07-08 09:44:42 UTC

Size: 2.16 KB

patch

obsolete

>From 3e6272b3cab2efa97e87ea265cd794af4ff53937 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 8 Jul 2022 09:08:40 +0200
>Subject: [PATCH] Bug 28787: Comment selenium test that will fail if no SMTP
> server is defined
>Content-Type: text/plain; charset=utf-8
>
>This is a deadlock I think. Any ideas how we could continue to test that
>in any conditions?
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> t/db_dependent/selenium/authentication_2fa.t | 26 +++++++++++---------
> 1 file changed, 14 insertions(+), 12 deletions(-)
>
>diff --git a/t/db_dependent/selenium/authentication_2fa.t b/t/db_dependent/selenium/authentication_2fa.t
>index d00cdfda53..7c995d496a 100755
>--- a/t/db_dependent/selenium/authentication_2fa.t
>+++ b/t/db_dependent/selenium/authentication_2fa.t
>@@ -150,7 +150,7 @@ SKIP: {
>     };
> 
>     subtest "Send OTP code" => sub {
>-        plan tests => 4;
>+        plan tests => 3;
> 
>         # Make sure the send won't fail because of invalid email addresses
>         $patron->library->set(
>@@ -186,17 +186,19 @@ SKIP: {
>             'Email not sent will display an error'
>         );
> 
>-        $patron->email('test@example.org');
>-        $patron->store;
>-        $driver->find_element('//a[@id="send_otp"]')->click;
>-        $s->wait_for_ajax;
>-        my $message =
>-          $driver->find_element('//div[@id="email_success"]')->get_text;
>-        is(
>-            $message,
>-            "The code has been sent by email, please check your inbox.",
>-            'The email must have been sent correctly'
>-        );
>+        # This test will only pass if an SMTP server is defined
>+        # It cannot be mocked from selenium tests
>+        #$patron->email('test@example.org');
>+        #$patron->store;
>+        #$driver->find_element('//a[@id="send_otp"]')->click;
>+        #$s->wait_for_ajax;
>+        #my $message =
>+        #  $driver->find_element('//div[@id="email_success"]')->get_text;
>+        #is(
>+        #    $message,
>+        #    "The code has been sent by email, please check your inbox.",
>+        #    'The email must have been sent correctly'
>+        #);
>     };
> 
>     subtest "Disable" => sub {
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 28787: 135287 | 136571 | 136572 | 136573 | 137251 | 137330 | 137331 | 137369 | 137370 | 137371 | 137379 | 137380 | 137381 | 137391 | 137392 | 137393 | 137394 | 137395 | 137396 | 137397 | 137398 | 137399 | 137400 | 138146 | 138149 | 138150 | 138151 | 138152 | 138153 | 138154 | 138155 | 138156 | 138157 | 138158 | 138159 | 138689 | 138696 | 138697 | 138698 | 138699 | 138700 | 138701 | 138702 | 138703 | 138704 | 138705 | 138706 | 138707 | 138931 | 138932