Attachment 137404 Details for Bug 31117 – Bug 31117: New message for cloning standard rules

[patch] Bug 31117: New message for cloning standard rules

Bug-31117-New-message-for-cloning-standard-rules.patch (text/plain), 2.12 KB, created by Katrin Fischer on 2022-07-08 11:19:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2022-07-08 11:19:57 UTC

Size: 2.12 KB

patch

obsolete

>From 2df2d68cb86de4e77eae495c3482c48b2d6e7fca Mon Sep 17 00:00:00 2001
>From: Florian Bontemps <florian.bontemps@biblibre.com>
>Date: Thu, 7 Jul 2022 15:24:10 +0000
>Subject: [PATCH] Bug 31117: New message for cloning standard rules
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>This commit adds a different message when cloning circulation and fine rules if you use the Standard rules for all libraries option.
>
>Test plan :
>1. Go to the Circulation and fine rules page in the Admin tab.
>2. Check that the 'Select a library' menu is on 'Standard rules for all libraries'.
>3. Check that you also have some random rules to clone, or create some.
>4. Clone these rules to the library of your choice.
>5. Confirm that the message 'Clone circulation and fine rules from "" to (library of your choice)' appears.
>6. Now clone rules from a specific library to another one, and repeat steps 3-4.
>7. Confirm that this time, the message will displays both libraries properly.
>8. Apply patch.
>9. Repeat steps 2 to 4 and 6 to 7. Confirm that this time, the message in the first case will be 'Cloning circulation and fine rules to "(library of your choice)"'.
>10. Kindly sign off.
>
>Signed-off-by: Emmanuel BÃ©temps <e.betemps@gmail.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/clone-rules.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/clone-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/clone-rules.tt
>index fa260548e2..f6dafcb936 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/clone-rules.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/clone-rules.tt
>@@ -35,7 +35,7 @@
>             <main>
> 
>     <h1>Cloning circulation and fine rules
>-        [% IF frombranch %] from "[% Branches.GetName( frombranch ) | html %]"[% END %]
>+        [% IF frombranch == "*" %] from standard rules[% ELSIF frombranch %] from "[% Branches.GetName( frombranch ) | html %]"[% END %]
>         [% IF tobranch %] to "[% Branches.GetName( tobranch ) | html %]"[% END %]
>     </h1>
> 
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 31117: 137327 | 137328 | 137329 | 137404