Attachment 137413 Details for Bug 30911 – Bug 30911: Datatables error on course-details.pl after adding a bib-level course reserve

[patch] Bug 30911: Datatables error on course-details.pl after adding a bib-level course reserve

Bug-30911-Datatables-error-on-course-detailspl-aft.patch (text/plain), 4.22 KB, created by Owen Leonard on 2022-07-08 13:27:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2022-07-08 13:27:35 UTC

Size: 4.22 KB

patch

obsolete

>From d0e33b2fb0ee4946acf0cae084c8b17bbc3f5891 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Fri, 8 Jul 2022 13:03:01 +0000
>Subject: [PATCH] Bug 30911: Datatables error on course-details.pl after adding
> a bib-level course reserve
>
>This patch removes the colspan from biblio-level course reserves rows in
>favor of adding a style to the message's container allowing it to
>overflow across table cells.
>
>To test, apply the patch and go to course reserves.
>
>1. If necessary, add a new course.
>2. View the details of the course and add a reserve using the
>   biblionumber option to add the reserve at the bibliographic level.
>3. Add a notes if you want, then click "Save."
>4. Return to the course detail view.
>5. In the table of reserves your biblio-level reserve should have a
>   message starting in the "Barcode" column and overflowing across other
>   item information columns, "Item information is not available for
>   record-level course reserve."
>6. Try adding multiple item-level and biblio-level reserves to the same
>   course to confirm that the information displays well in those cases.
>---
> .../modules/course_reserves/course-details.tt | 48 ++++++++++++-------
> 1 file changed, 32 insertions(+), 16 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-details.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-details.tt
>index 0b706dc761..b6332e5902 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-details.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-details.tt
>@@ -9,15 +9,26 @@
> [% INCLUDE 'doc-head-open.inc' %]
> <title>Course details for [% course.course_name | html %] &rsaquo; Course reserves &rsaquo; Koha</title>
> [% INCLUDE 'doc-head-close.inc' %]
>-
>-<style>
>-    #instructors {
>-        float: left;
>-    }
>-    .instructor_line {
>-        padding: 0 .1em;
>-    }
>-</style>
>+[% FILTER collapse %]
>+    <style>
>+        #instructors {
>+            float: left;
>+        }
>+        .instructor_line {
>+            padding: 0 .1em;
>+        }
>+        .biblio-level-info {
>+            background-color: #f3f3f3;
>+            border-radius:5px;
>+            box-shadow: 0px 1px 1px 0px rgba(50, 50, 50, 0.2);
>+            display:block;
>+            font-style: italic;
>+            margin: -3px 0 0 -3px;
>+            padding:.5em;
>+            position:absolute;
>+        }
>+    </style>
>+[% END %]
> </head>
> 
> <body id="courses_course_details" class="course">
>@@ -121,6 +132,9 @@
> 
>                             [% IF cr.item %]
>                                 <td><a href="/cgi-bin/koha/catalogue/moredetail.pl?itemnumber=[% cr.item.itemnumber | uri %]&amp;biblionumber=[% cr.biblio.biblionumber | uri %]&amp;bi=[% cr.biblioitem.biblioitemnumber | uri %]">[% cr.item.barcode | html %]</a></td>
>+
>+
>+
>                                 <td>[% cr.item.itemcallnumber | html %]</td>
>                                 [% IF item_level_itypes %]
>                                 <td>
>@@ -221,13 +235,15 @@
>                                     [% END %]
>                                 </td>
>                             [% ELSE # record-level course reserve %]
>-                                [% IF ( item_level_itypes ) %]
>-                                    <td colspan="7">
>-                                [% ELSE %]
>-                                    <td colspan="6">
>-                                [% END %]
>-                                        <em>Information not available for record-level course reserve</em>
>-                                    </td>
>+                                <td>
>+                                    <div class="biblio-level-info">Item information is not available for record-level course reserve</div>
>+                                </td>
>+                                <td></td>
>+                                <td></td>
>+                                <td></td>
>+                                <td></td>
>+                                <td></td>
>+                                <td></td>
>                             [% END %]
> 
>                             <td>[% IF (cr.staff_note) %]
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 30911: 137413 | 137426 | 137427