Bugzilla – Attachment 137572 Details for
Bug 29105
Add effective_item_type_id to the API items responses
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29105: Unit test
Bug-29105-Unit-test.patch (text/plain), 2.04 KB, created by
Nick Clemens (kidclamp)
on 2022-07-11 16:09:14 UTC
(
hide
)
Description:
Bug 29105: Unit test
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2022-07-11 16:09:14 UTC
Size:
2.04 KB
patch
obsolete
>From 89fbd195bd804ad5558eccbc0725f2129796d806 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Fri, 24 Sep 2021 15:13:55 +0100 >Subject: [PATCH] Bug 29105: Unit test > >This patch adds a unit test for the addition of effective_item_type_id >to the items responses. > >Test plan >1) Run the unit test prior to applying the second patch and confirm it > fails >2) Apply the second patch and confirm the unit test now passes > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > t/db_dependent/api/v1/items.t | 22 +++++++++++++++++++++- > 1 file changed, 21 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/api/v1/items.t b/t/db_dependent/api/v1/items.t >index 0d4f4c0ea4..41f574ccf7 100755 >--- a/t/db_dependent/api/v1/items.t >+++ b/t/db_dependent/api/v1/items.t >@@ -101,7 +101,7 @@ subtest 'list() tests' => sub { > > subtest 'get() tests' => sub { > >- plan tests => 9; >+ plan tests => 17; > > $schema->storage->txn_begin; > >@@ -139,6 +139,26 @@ subtest 'get() tests' => sub { > ->status_is(404) > ->json_is( '/error' => 'Item not found' ); > >+ t::lib::Mocks::mock_preference( 'item-level_itypes', 0 ); >+ >+ my $biblio = $builder->build_sample_biblio; >+ my $itype = >+ $builder->build_object( { class => 'Koha::ItemTypes' } )->itemtype; >+ $item = $builder->build_sample_item( >+ { biblionumber => $biblio->biblionumber, itype => $itype } ); >+ >+ $t->get_ok( "//$userid:$password@/api/v1/items/" . $item->itemnumber ) >+ ->status_is( 200, 'SWAGGER3.2.2' ) >+ ->json_is( '/item_type_id' => $itype, 'item-level_itypes:0' ) >+ ->json_is( '/effective_item_type_id' => $biblio->itemtype, 'item-level_itypes:0' ); >+ >+ t::lib::Mocks::mock_preference( 'item-level_itypes', 1 ); >+ >+ $t->get_ok( "//$userid:$password@/api/v1/items/" . $item->itemnumber ) >+ ->status_is( 200, 'SWAGGER3.2.2' ) >+ ->json_is( '/item_type_id' => $itype, 'item-level_itype:1' ) >+ ->json_is( '/effective_item_type_id' => $itype, 'item-level_itypes:1' ); >+ > $schema->storage->txn_rollback; > }; > >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29105
:
125235
|
125251
|
125252
|
137504
|
137505
| 137572 |
137573