Attachment 137590 Details for Bug 20439 – Bug 20439: Sort SMS providers in alphabetical order

[patch] Bug 20439: Sort SMS providers in alphabetical order

Bug-20439-Sort-SMS-providers-in-alphabetical-order.patch (text/plain), 2.27 KB, created by ByWater Sandboxes on 2022-07-11 20:41:31 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: ByWater Sandboxes

Created: 2022-07-11 20:41:31 UTC

Size: 2.27 KB

patch

obsolete

>From 514513b7c84a5d1298311b249e795539c52c0e82 Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Mon, 11 Jul 2022 19:58:46 +0000
>Subject: [PATCH] Bug 20439: Sort SMS providers in alphabetical order
>
>To test:
>1/ Add 'Email' to the 'SMSSendDriver' system preference.
>2/ Make sure 'EnhancedMessagingPreferencesOPAC' and 'EnhancedMessagingPreferences' are turned on.
>3/ Add some SMS providers (/cgi-bin/koha/admin/sms_providers.pl) with different names.
>4/ Notice on memberentry.pl and opac-messaging.pl the SMS providers sort by when they were added, not alphabetically.
>5/ Apply patch and restart services.
>6/ Look at memberentry.pl and opac-messaging.pl and notice that they SMS providers now sort alphabetically.
>
>Signed-off-by: George Williams <george@nekls.org>
>---
> members/memberentry.pl | 3 ++-
> opac/opac-messaging.pl | 5 +++--
> 2 files changed, 5 insertions(+), 3 deletions(-)
>
>diff --git a/members/memberentry.pl b/members/memberentry.pl
>index d406817ecd..5b4a7ba131 100755
>--- a/members/memberentry.pl
>+++ b/members/memberentry.pl
>@@ -69,7 +69,8 @@ if ( $borrowernumber and not $patron ) {
> 
> if ( C4::Context->preference('SMSSendDriver') eq 'Email' ) {
>     my @providers = Koha::SMS::Providers->search->as_list;
>-    $template->param( sms_providers => \@providers );
>+    my @sorted_providers = sort { $a->name cmp $b->name } @providers;
>+    $template->param( sms_providers => \@sorted_providers );
> }
> 
> my $actionType     = $input->param('actionType') || '';
>diff --git a/opac/opac-messaging.pl b/opac/opac-messaging.pl
>index 01faeb3cf4..cea8ea0642 100755
>--- a/opac/opac-messaging.pl
>+++ b/opac/opac-messaging.pl
>@@ -79,8 +79,9 @@ $template->param(
>                   TalkingTechItivaPhone        =>  C4::Context->preference("TalkingTechItivaPhoneNotification") );
> 
> if ( C4::Context->preference("SMSSendDriver") eq 'Email' ) {
>-    my $providers = Koha::SMS::Providers->search;
>-    $template->param( sms_providers => $providers, sms_provider_id => $patron->sms_provider_id );
>+    my @providers = Koha::SMS::Providers->search->as_list;
>+    my @sorted_providers = sort { $a->name cmp $b->name } @providers;
>+    $template->param( sms_providers => \@sorted_providers, sms_provider_id => $patron->sms_provider_id );
> }
> 
> my $new_session_id = $query->cookie('CGISESSID');
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 20439: 137579 | 137590 | 137786 | 137800