Bugzilla – Attachment 137638 Details for
Bug 31086
Do not allow hold requests with no branchcode
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31086: DO NOT PUSH: Schema updates
Bug-31086-DO-NOT-PUSH-Schema-updates.patch (text/plain), 2.09 KB, created by
Martin Renvoize (ashimema)
on 2022-07-12 15:24:56 UTC
(
hide
)
Description:
Bug 31086: DO NOT PUSH: Schema updates
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2022-07-12 15:24:56 UTC
Size:
2.09 KB
patch
obsolete
>From 03695b57288cf1c2ea55aabf4a231b4c69fc2638 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 1 Jul 2022 14:52:45 +0000 >Subject: [PATCH] Bug 31086: DO NOT PUSH: Schema updates > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > Koha/Schema/Result/Reserve.pm | 22 ++++++++++++---------- > 1 file changed, 12 insertions(+), 10 deletions(-) > >diff --git a/Koha/Schema/Result/Reserve.pm b/Koha/Schema/Result/Reserve.pm >index 04b81a1960..956c89ebe6 100644 >--- a/Koha/Schema/Result/Reserve.pm >+++ b/Koha/Schema/Result/Reserve.pm >@@ -60,8 +60,9 @@ foreign key from the biblio table defining which bib record this hold is on > =head2 branchcode > > data_type: 'varchar' >+ default_value: 0 > is_foreign_key: 1 >- is_nullable: 1 >+ is_nullable: 0 > size: 10 > > foreign key from the branches table defining which branch the patron wishes to pick this hold up at >@@ -236,7 +237,13 @@ __PACKAGE__->add_columns( > is_nullable => 0, > }, > "branchcode", >- { data_type => "varchar", is_foreign_key => 1, is_nullable => 1, size => 10 }, >+ { >+ data_type => "varchar", >+ default_value => 0, >+ is_foreign_key => 1, >+ is_nullable => 0, >+ size => 10, >+ }, > "desk_id", > { data_type => "integer", is_foreign_key => 1, is_nullable => 1 }, > "notificationdate", >@@ -347,12 +354,7 @@ __PACKAGE__->belongs_to( > "branchcode", > "Koha::Schema::Result::Branch", > { branchcode => "branchcode" }, >- { >- is_deferrable => 1, >- join_type => "LEFT", >- on_delete => "CASCADE", >- on_update => "CASCADE", >- }, >+ { is_deferrable => 1, on_delete => "CASCADE", on_update => "CASCADE" }, > ); > > =head2 club_holds_to_patron_holds >@@ -431,8 +433,8 @@ __PACKAGE__->belongs_to( > ); > > >-# Created by DBIx::Class::Schema::Loader v0.07049 @ 2022-01-28 20:08:09 >-# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:7Q8/GFCOkXdn+jg69HZ0GQ >+# Created by DBIx::Class::Schema::Loader v0.07049 @ 2022-07-01 14:52:08 >+# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:TvHwCkW9pQCFBc1wX9f2vg > > __PACKAGE__->belongs_to( > "item", >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31086
:
136983
|
136984
|
136986
|
136987
|
137026
|
137254
|
137255
|
137256
|
137257
|
137258
|
137635
|
137636
|
137637
| 137638 |
137639
|
137640
|
137641
|
137642
|
138006
|
138018
|
138051
|
144824