Bugzilla – Attachment 137640 Details for
Bug 31086
Do not allow hold requests with no branchcode
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31086: (QA follow-up) Remove DEFAULT from column
Bug-31086-QA-follow-up-Remove-DEFAULT-from-column.patch (text/plain), 2.82 KB, created by
Martin Renvoize (ashimema)
on 2022-07-12 15:25:06 UTC
(
hide
)
Description:
Bug 31086: (QA follow-up) Remove DEFAULT from column
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2022-07-12 15:25:06 UTC
Size:
2.82 KB
patch
obsolete
>From cf39185ad5206b47d769d4e6f488b81994355f65 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Tue, 12 Jul 2022 15:39:37 +0100 >Subject: [PATCH] Bug 31086: (QA follow-up) Remove DEFAULT from column > >There's no need to have a default here, and in fact it doesn't make >sense. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > .../bug_31086_do_not_allow_null_branchcode_in_reserves.pl | 2 +- > installer/data/mysql/kohastructure.sql | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/installer/data/mysql/atomicupdate/bug_31086_do_not_allow_null_branchcode_in_reserves.pl b/installer/data/mysql/atomicupdate/bug_31086_do_not_allow_null_branchcode_in_reserves.pl >index f0635e1f2c..1c817a2f26 100755 >--- a/installer/data/mysql/atomicupdate/bug_31086_do_not_allow_null_branchcode_in_reserves.pl >+++ b/installer/data/mysql/atomicupdate/bug_31086_do_not_allow_null_branchcode_in_reserves.pl >@@ -8,7 +8,7 @@ return { > my ($dbh, $out) = @$args{qw(dbh out)}; > $dbh->do(q{ > ALTER TABLE reserves >- MODIFY COLUMN `branchcode` varchar(10) COLLATE utf8mb4_unicode_ci NOT NULL DEFAULT 0 COMMENT 'foreign key from the branches table defining which branch the patron wishes to pick this hold up at' >+ MODIFY COLUMN `branchcode` varchar(10) COLLATE utf8mb4_unicode_ci NOT NULL COMMENT 'foreign key from the branches table defining which branch the patron wishes to pick this hold up at' > }); > # Print useful stuff here > say $out "Removed NULL option from branchcode for reserves"; >diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql >index d3a9492923..296330e990 100644 >--- a/installer/data/mysql/kohastructure.sql >+++ b/installer/data/mysql/kohastructure.sql >@@ -4439,7 +4439,7 @@ CREATE TABLE `reserves` ( > `borrowernumber` int(11) NOT NULL DEFAULT 0 COMMENT 'foreign key from the borrowers table defining which patron this hold is for', > `reservedate` date DEFAULT NULL COMMENT 'the date the hold was placed', > `biblionumber` int(11) NOT NULL DEFAULT 0 COMMENT 'foreign key from the biblio table defining which bib record this hold is on', >- `branchcode` varchar(10) COLLATE utf8mb4_unicode_ci NOT NULL DEFAULT 0 COMMENT 'foreign key from the branches table defining which branch the patron wishes to pick this hold up at', >+ `branchcode` varchar(10) COLLATE utf8mb4_unicode_ci NOT NULL COMMENT 'foreign key from the branches table defining which branch the patron wishes to pick this hold up at', > `desk_id` int(11) DEFAULT NULL COMMENT 'foreign key from the desks table defining which desk the patron should pick this hold up at', > `notificationdate` date DEFAULT NULL COMMENT 'currently unused', > `reminderdate` date DEFAULT NULL COMMENT 'currently unused', >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31086
:
136983
|
136984
|
136986
|
136987
|
137026
|
137254
|
137255
|
137256
|
137257
|
137258
|
137635
|
137636
|
137637
|
137638
|
137639
| 137640 |
137641
|
137642
|
138006
|
138018
|
138051
|
144824