Bugzilla – Attachment 137641 Details for
Bug 31086
Do not allow hold requests with no branchcode
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31086: (QA follow-up) Fix failing tests
Bug-31086-QA-follow-up-Fix-failing-tests.patch (text/plain), 2.22 KB, created by
Martin Renvoize (ashimema)
on 2022-07-12 15:25:11 UTC
(
hide
)
Description:
Bug 31086: (QA follow-up) Fix failing tests
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2022-07-12 15:25:11 UTC
Size:
2.22 KB
patch
obsolete
>From fdd9b8333aada29d24200d8af4bbd37ef422397b Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Tue, 12 Jul 2022 16:21:30 +0100 >Subject: [PATCH] Bug 31086: (QA follow-up) Fix failing tests > >This test was missed first time around, branchcode needed adding to all >the calls to AddReserve. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > t/db_dependent/Koha/Holds.t | 6 ++++++ > 1 file changed, 6 insertions(+) > >diff --git a/t/db_dependent/Koha/Holds.t b/t/db_dependent/Koha/Holds.t >index d9f8b666a7..6d47bf2a62 100755 >--- a/t/db_dependent/Koha/Holds.t >+++ b/t/db_dependent/Koha/Holds.t >@@ -432,10 +432,13 @@ subtest 'get_items_that_can_fill' => sub { > my $patron_2 = $builder->build_object( { class => 'Koha::Patrons' } ); > my $patron_3 = $builder->build_object( { class => 'Koha::Patrons' } ); > >+ my $library_1 = $builder->build_object( { class => 'Koha::Libraries' } ); >+ > t::lib::Mocks::mock_userenv( { patron => $patron_1 } ); > > my $reserve_id_1 = C4::Reserves::AddReserve( > { >+ branchcode => $library_1->branchcode, > borrowernumber => $patron_1->borrowernumber, > biblionumber => $biblio->biblionumber, > priority => 1, >@@ -449,6 +452,7 @@ subtest 'get_items_that_can_fill' => sub { > > my $reserve_id_2 = C4::Reserves::AddReserve( > { >+ branchcode => $library_1->branchcode, > borrowernumber => $patron_2->borrowernumber, > biblionumber => $biblio->biblionumber, > priority => 2, >@@ -458,6 +462,7 @@ subtest 'get_items_that_can_fill' => sub { > > my $waiting_reserve_id = C4::Reserves::AddReserve( > { >+ branchcode => $library_1->branchcode, > borrowernumber => $patron_2->borrowernumber, > biblionumber => $biblio->biblionumber, > priority => 0, >@@ -468,6 +473,7 @@ subtest 'get_items_that_can_fill' => sub { > > my $notforloan_reserve_id = C4::Reserves::AddReserve( > { >+ branchcode => $library_1->branchcode, > borrowernumber => $patron_2->borrowernumber, > biblionumber => $biblio->biblionumber, > priority => 0, >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31086
:
136983
|
136984
|
136986
|
136987
|
137026
|
137254
|
137255
|
137256
|
137257
|
137258
|
137635
|
137636
|
137637
|
137638
|
137639
|
137640
| 137641 |
137642
|
138006
|
138018
|
138051
|
144824