Bugzilla – Attachment 137655 Details for
Bug 12225
SIP does not respect the "no block" flag
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12225: Fix SIP message templates
Bug-12225-Fix-SIP-message-templates.patch (text/plain), 3.40 KB, created by
David Nind
on 2022-07-12 19:12:19 UTC
(
hide
)
Description:
Bug 12225: Fix SIP message templates
Filename:
MIME Type:
Creator:
David Nind
Created:
2022-07-12 19:12:19 UTC
Size:
3.40 KB
patch
obsolete
>From 5c19b3f376c1648d47bc1f5554d4f1a5a507e7f2 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Mon, 11 Jul 2022 16:57:06 +0000 >Subject: [PATCH] Bug 12225: Fix SIP message templates > >If a renewal via SIP would produce an error due to being on reserve, or exceeding maximum renewals, Koha's SIP2 implementation will refuse to renew the item even if the "no block" flag is set to Y. > >Signed-off-by: David Nind <david@davidnind.com> >--- > C4/SIP/Sip/MsgType.pm | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > >diff --git a/C4/SIP/Sip/MsgType.pm b/C4/SIP/Sip/MsgType.pm >index 2f7ba7da0f..0de5f1facc 100644 >--- a/C4/SIP/Sip/MsgType.pm >+++ b/C4/SIP/Sip/MsgType.pm >@@ -72,12 +72,12 @@ my %handlers = ( > handler => \&handle_checkout, > protocol => { > 1 => { >- template => "CCA18A18", >+ template => "A1A1A18A18", > template_len => 38, > fields => [ (FID_INST_ID), (FID_PATRON_ID), (FID_ITEM_ID), (FID_TERMINAL_PWD) ], > }, > 2 => { >- template => "CCA18A18", >+ template => "A1A1A18A18", > template_len => 38, > fields => [ (FID_INST_ID), (FID_PATRON_ID), (FID_ITEM_ID), (FID_TERMINAL_PWD), (FID_ITEM_PROPS), (FID_PATRON_PWD), (FID_FEE_ACK), (FID_CANCEL) ], > }, >@@ -88,12 +88,12 @@ my %handlers = ( > handler => \&handle_checkin, > protocol => { > 1 => { >- template => "CA18A18", >+ template => "A1A18A18", > template_len => 37, > fields => [ (FID_CURRENT_LOCN), (FID_INST_ID), (FID_ITEM_ID), (FID_TERMINAL_PWD) ], > }, > 2 => { >- template => "CA18A18", >+ template => "A1A18A18", > template_len => 37, > fields => [ (FID_CURRENT_LOCN), (FID_INST_ID), (FID_ITEM_ID), (FID_TERMINAL_PWD), (FID_ITEM_PROPS), (FID_CANCEL) ], > } >@@ -104,7 +104,7 @@ my %handlers = ( > handler => \&handle_block_patron, > protocol => { > 1 => { >- template => "CA18", >+ template => "A1A18", > template_len => 19, > fields => [ (FID_INST_ID), (FID_BLOCKED_CARD_MSG), (FID_PATRON_ID), (FID_TERMINAL_PWD) ], > }, >@@ -115,7 +115,7 @@ my %handlers = ( > handler => \&handle_sc_status, > protocol => { > 1 => { >- template => "CA3A4", >+ template => "A1A3A4", > template_len => 8, > fields => [], > } >@@ -126,7 +126,7 @@ my %handlers = ( > handler => \&handle_request_acs_resend, > protocol => { > 1 => { >- template => "", >+ template => q{}, > template_len => 0, > fields => [], > } >@@ -228,7 +228,7 @@ my %handlers = ( > handler => \&handle_renew, > protocol => { > 2 => { >- template => "CCA18A18", >+ template => "A1A1A18A18", > template_len => 38, > fields => [ (FID_INST_ID), (FID_PATRON_ID), (FID_PATRON_PWD), (FID_ITEM_ID), (FID_TITLE_ID), (FID_TERMINAL_PWD), (FID_ITEM_PROPS), (FID_FEE_ACK) ], > } >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12225
:
37446
|
137578
|
137622
|
137655
|
137656
|
137683
|
137712
|
137713
|
139684
|
139685
|
139686
|
139691
|
139706
|
139707
|
139708
|
139709
|
139710