Attachment 137669 Details for Bug 30847 – Bug 30847: Remove unused noreserve parameter

[patch] Bug 30847: Remove unused noreserve parameter

Bug-30847-Remove-unused-noreserve-parameter.patch (text/plain), 996 bytes, created by Jonathan Druart on 2022-07-13 06:40:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2022-07-13 06:40:59 UTC

Size: 996 bytes

patch

obsolete

>From 8c02774ec0e98809385ffd02957a87e5d4bf666b Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Wed, 25 May 2022 14:00:16 +0000
>Subject: [PATCH] Bug 30847: Remove unused noreserve parameter
>
>This is defined but never used
>
>To test:
>1 - git grep noreserve
>2 - only one ocurrence
>3 - Apply patch
>4 - repeat, no ocurrence
>5 - Note the plural has a few uses
>---
> opac/opac-reserve.pl | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/opac/opac-reserve.pl b/opac/opac-reserve.pl
>index ae596a12dc3..fb019955e4b 100755
>--- a/opac/opac-reserve.pl
>+++ b/opac/opac-reserve.pl
>@@ -332,7 +332,6 @@ if ( $query->param('place_reserve') ) {
> #
> my $noreserves     = 0;
> my $maxoutstanding = C4::Context->preference("maxoutstanding");
>-$template->param( noreserve => 1 ) unless $maxoutstanding;
> my $amountoutstanding = $patron->account->balance;
> if ( $amountoutstanding && ($amountoutstanding > $maxoutstanding) ) {
>     my $amount = sprintf "%.02f", $amountoutstanding;
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 30847: 135340 | 135341 | 135342 | 135343 | 135344 | 135345 | 135346 | 135347 | 135348 | 137668 | 137669 | 137670 | 137671 | 137672 | 137673 | 137674 | 137675 | 138654 | 138655 | 138934 | 138935 | 138936 | 138937 | 138938 | 138939 | 138940 | 138941 | 139628 | 139629 | 139630 | 139631 | 139632 | 139633 | 139634 | 139635 | 139915 | 139916 | 139917 | 139918 | 139919 | 139920 | 139921 | 139922 | 139923