Attachment 137697 Details for Bug 31120 – Bug 31120 - Items will renew for zero ( 0 ) days if renewalperiod is blank/empty value

[patch] Bug 31120 - Items will renew for zero ( 0 ) days if renewalperiod is blank/empty value

Bug-31120---Items-will-renew-for-zero--0--days-if-.patch (text/plain), 1.58 KB, created by Martin Renvoize (ashimema) on 2022-07-14 09:22:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2022-07-14 09:22:38 UTC

Size: 1.58 KB

patch

obsolete

>From 1cc3ee40930b272661cee7def61d13147631d587 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Thu, 7 Jul 2022 15:14:59 -0400
>Subject: [PATCH] Bug 31120 - Items will renew for zero ( 0 ) days if
> renewalperiod is blank/empty value
>
>If the rule renewalperiod is the blank empty string instead of being null/undefined or non-existant, Koha will interpret the renewal period as being zero days instead of falling back to the issuelength rule.
>
>It makes sense to me that a literal 0 here should make it renew for zero days even though that is nonsensical.
>
>Test Plan:
>1) Delete all your rules
>2) Create an all/all/all rules with an empty string for renewal base
>   period
>3) Note that renewing an item does nothing
>4) Apply this patch
>5) Restart all the things!
>6) Renew again
>7) Note the renewal uses the issuelength rule as intended
>
>Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> C4/Circulation.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/C4/Circulation.pm b/C4/Circulation.pm
>index a18864dea7..5b57575f3b 100644
>--- a/C4/Circulation.pm
>+++ b/C4/Circulation.pm
>@@ -3759,7 +3759,7 @@ sub CalcDateDue {
>     my $loanlength =
>             GetLoanLength( $borrower->{'categorycode'}, $itemtype, $branch );
> 
>-    my $length_key = ( $isrenewal and defined $loanlength->{renewalperiod} )
>+    my $length_key = ( $isrenewal and defined $loanlength->{renewalperiod} and $loanlength->{renewalperiod} ne q{} )
>             ? qq{renewalperiod}
>             : qq{issuelength};
> 
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 31120: 137333 | 137526 | 137697 | 137708 | 137709 | 137769 | 138177 | 138178