Bugzilla – Attachment 137713 Details for
Bug 12225
SIP does not respect the "no block" flag
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12225: Use ProcessOfflineIssue
Bug-12225-Use-ProcessOfflineIssue.patch (text/plain), 2.21 KB, created by
David Nind
on 2022-07-14 12:12:40 UTC
(
hide
)
Description:
Bug 12225: Use ProcessOfflineIssue
Filename:
MIME Type:
Creator:
David Nind
Created:
2022-07-14 12:12:40 UTC
Size:
2.21 KB
patch
obsolete
>From de26bbf87517823170e8a45090f0af0cc4ab3dd0 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Wed, 13 Jul 2022 14:31:09 +0000 >Subject: [PATCH] Bug 12225: Use ProcessOfflineIssue > >Signed-off-by: David Nind <david@davidnind.com> >--- > C4/Circulation.pm | 1 + > C4/SIP/ILS/Transaction/Checkout.pm | 24 ++++++++++++++---------- > 2 files changed, 15 insertions(+), 10 deletions(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index a18864dea7..dc3a9587e4 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -124,6 +124,7 @@ BEGIN { > DeleteOfflineOperation > ProcessOfflineOperation > ProcessOfflinePayment >+ ProcessOfflineIssue > ); > push @EXPORT_OK, '_GetCircControlBranch'; # This is wrong! > } >diff --git a/C4/SIP/ILS/Transaction/Checkout.pm b/C4/SIP/ILS/Transaction/Checkout.pm >index c1c1e18eeb..ab451e9a46 100644 >--- a/C4/SIP/ILS/Transaction/Checkout.pm >+++ b/C4/SIP/ILS/Transaction/Checkout.pm >@@ -15,7 +15,7 @@ use CGI qw ( -utf8 ); > use C4::SIP::ILS::Transaction; > > use C4::Context; >-use C4::Circulation qw( AddIssue GetIssuingCharges CanBookBeIssued ); >+use C4::Circulation qw( AddIssue GetIssuingCharges CanBookBeIssued ProcessOfflineIssue ); > use C4::Members; > use Koha::DateUtils qw( dt_from_string ); > >@@ -127,19 +127,23 @@ sub do_checkout { > } > } > >- if ( $no_block_due_date ) { >- $overridden_duedate = $no_block_due_date; >- $noerror = 1; >- } >- >- unless ($noerror) { >+ if ( $noerror == 0 && !$no_block_due_date ) { > $self->ok(0); > return $self; > } > >- # can issue >- my $issue = AddIssue( $patron->unblessed, $barcode, $overridden_duedate, 0 ); >- $self->{due} = $self->duedatefromissue($issue, $itemnumber); >+ if ( $no_block_due_date ) { >+ $overridden_duedate = $no_block_due_date; >+ ProcessOfflineIssue({ >+ cardnumber => $patron->cardnumber, >+ barcode => $barcode, >+ timestamp => $no_block_due_date, >+ }); >+ } else { >+ # can issue >+ my $issue = AddIssue( $patron->unblessed, $barcode, $overridden_duedate, 0 ); >+ $self->{due} = $self->duedatefromissue($issue, $itemnumber); >+ } > > $self->ok(1); > return $self; >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12225
:
37446
|
137578
|
137622
|
137655
|
137656
|
137683
|
137712
|
137713
|
139684
|
139685
|
139686
|
139691
|
139706
|
139707
|
139708
|
139709
|
139710