Attachment 13779 Details for Bug 7687 – Bug 7687 - Remove problematic CSS gradient declarations targeting Internet Explorer

[patch] Bug 7687 - Remove problematic CSS gradient declarations targeting Internet Explorer

Bug-7687---Remove-problematic-CSS-gradient-declara.patch (text/plain), 7.94 KB, created by Paul Poulain on 2012-11-29 17:00:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Paul Poulain

Created: 2012-11-29 17:00:08 UTC

Size: 7.94 KB

patch

obsolete

>From 3d6f96a6622837643f34a6dbbcbc18e6130aaea8 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Tue, 30 Oct 2012 14:10:53 -0400
>Subject: [PATCH] Bug 7687 - Remove problematic CSS gradient declarations
> targeting Internet Explorer
>
>Removing and revising some CSS which causes problems in
>Internet Explorer:
>
>- User sidebar menu tabs in the OPAC
>- Sidebar menu tabs in the staff client (circ, catalog, etc)
>- List edit/delete buttons in the OPAC (when viewing the
>  list of lists and viewing a list itself).
>
>Also fixed is the sprite positioning for the "new list"
>link which showed the wrong icon.
>
>Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
>
>I tested this in Firefox, and Chromium and it didn't break anything,
>I trust it works for IE too.
>
>Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
>---
> .../intranet-tmpl/prog/en/css/staff-global.css     |    6 +-----
> koha-tmpl/opac-tmpl/prog/en/css/opac.css           |   18 +++++++-----------
> 2 files changed, 8 insertions(+), 16 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
>index 63bd81c..a8897a0 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
>+++ b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
>@@ -1157,7 +1157,7 @@ div.message {
> 	background: -webkit-linear-gradient(top, #ffffff 0%,#f4f6fa 2%,#eaeef5 23%,#e8edf6 94%,#cddbf2 100%); /* Chrome10+,Safari5.1+ */
> 	background: -o-linear-gradient(top, #ffffff 0%,#f4f6fa 2%,#eaeef5 23%,#e8edf6 94%,#cddbf2 100%); /* Opera11.10+ */
> 	background: -ms-linear-gradient(top, #ffffff 0%,#f4f6fa 2%,#eaeef5 23%,#e8edf6 94%,#cddbf2 100%); /* IE10+ */
>-	filter: progid:DXImageTransform.Microsoft.gradient( startColorstr='#ffffff', endColorstr='#cddbf2',GradientType=0 ); /* IE6-9 */
>+    filter: progid:DXImageTransform.Microsoft.gradient( startColorstr='#eaeef5', endColorstr='#cddbf2',GradientType=0 ); /* IE6-9 */
> 	background: linear-gradient(top, #ffffff 0%,#f4f6fa 2%,#eaeef5 23%,#e8edf6 94%,#cddbf2 100%); /* W3C */
>   	border : 1px solid #bcbcbc;
>   	text-align: center;
>@@ -1252,7 +1252,6 @@ div#menu li a {
>     background: -webkit-linear-gradient(left, #e8f0f6 0%,#e8f0f6 96%,#c1c1c1 100%); /* Chrome10+,Safari5.1+ */
>      background: -o-linear-gradient(left, #e8f0f6 0%,#e8f0f6 96%,#c1c1c1 100%); /* Opera11.10+ */
>    background: -ms-linear-gradient(left, #e8f0f6 0%,#e8f0f6 96%,#c1c1c1 100%); /* IE10+ */
>-        filter: progid:DXImageTransform.Microsoft.gradient( startColorstr='#e8f0f6', endColorstr='#c1c1c1',GradientType=1 ); /* IE6-9 */
>        background: linear-gradient(left, #e8f0f6 0%,#e8f0f6 96%,#c1c1c1 100%); /* W3C */
> 	-moz-border-top-left-radius: 5px;
> 	border-top-left-radius: 5px;
>@@ -1266,15 +1265,12 @@ div#menu li a {
> }
> 
> div#menu li a:hover {
>-
>-
>      background: #fff; /* Old browsers */
>    background: -moz-linear-gradient(left, #FAFAFA 0%, #FAFAFA 96%, #e6e6e6 97%, #cccccc 99%, #c1c1c1 100%); /* FF3.6+ */
>   background: -webkit-gradient(linear, left top, right top, color-stop(0%,#FAFAFA), color-stop(96%,#FAFAFA), color-stop(97%,#e6e6e6), color-stop(99%,#cccccc), color-stop(100%,#c1c1c1)); /* Chrome,Safari4+ */
>   background: -webkit-linear-gradient(left, #FAFAFA 0%,#FAFAFA 96%,#e6e6e6 97%,#cccccc 99%,#c1c1c1 100%); /* Chrome10+,Safari5.1+ */
>      background: -o-linear-gradient(left, #FAFAFA 0%,#FAFAFA 96%,#e6e6e6 97%,#cccccc 99%,#c1c1c1 100%); /* Opera11.10+ */
>    background: -ms-linear-gradient(left, #FAFAFA 0%,#FAFAFA 96%,#e6e6e6 97%,#cccccc 99%,#c1c1c1 100%); /* IE10+ */
>-        filter: progid:DXImageTransform.Microsoft.gradient( startColorstr='#eeeeee', endColorstr='#c1c1c1',GradientType=1 ); /* IE6-9 */
>        background: linear-gradient(left, #FAFAFA 0%,#fff 96%,#e6e6e6 97%,#cccccc 99%,#c1c1c1 100%); /* W3C */
>     border-left: 1px solid #85CA11;
>     border-top: 1px solid #85CA11;
>diff --git a/koha-tmpl/opac-tmpl/prog/en/css/opac.css b/koha-tmpl/opac-tmpl/prog/en/css/opac.css
>index aad1b2c..06e6bcf 100644
>--- a/koha-tmpl/opac-tmpl/prog/en/css/opac.css
>+++ b/koha-tmpl/opac-tmpl/prog/en/css/opac.css
>@@ -649,12 +649,11 @@ a.send {
> 
> #toolbar input.editshelf,
> input.editshelf {
>-    background-image : url("../../images/sprite.png");
>-    background-position : 2px -732px;
>-    background-repeat: no-repeat;
>+    background : transparent url("../../images/sprite.png") 2px -732px no-repeat;
> 	border : 0;
> 	color : #006699;
> 	cursor : pointer;
>+    filter: none;
> 	font-size : 100%;
> 	padding-left : 29px;
> 	text-decoration : none;
>@@ -664,11 +663,12 @@ input.editshelf {
> #toolbar a.newshelf,
> a.newshelf {
>     background-image: url("../../images/sprite.png"); /* add to list icon */
>-    background-position: -4px -864px;
>+    background-position: -4px -764px;
>     background-repeat: no-repeat;
> 	border : 0;
> 	color : #006699;
> 	cursor : pointer;
>+    filter: none;
> 	font-size : 100%;
> 	margin: 0 0.5em;
>     padding-left : 23px;
>@@ -683,12 +683,11 @@ a.newshelf.disabled {
> 
> #toolbar input.deleteshelf,
> input.deleteshelf {
>-    background-image : url("../../images/sprite.png");
>-    background-position : 2px -685px;
>-    background-repeat: no-repeat;
>+    background : transparent url("../../images/sprite.png") 2px -685px no-repeat;
> 	border : 0;
> 	color : #006699;
> 	cursor : pointer;
>+    filter: none;
> 	font-size : 100%;
>     padding-left : 25px;
> 	text-decoration : none;
>@@ -1538,7 +1537,7 @@ div.message {
> 	background: -webkit-linear-gradient(top, #ffffff 0%,#f4f6fa 2%,#eaeef5 23%,#e8edf6 94%,#cddbf2 100%); /* Chrome10+,Safari5.1+ */
> 	background: -o-linear-gradient(top, #ffffff 0%,#f4f6fa 2%,#eaeef5 23%,#e8edf6 94%,#cddbf2 100%); /* Opera11.10+ */
> 	background: -ms-linear-gradient(top, #ffffff 0%,#f4f6fa 2%,#eaeef5 23%,#e8edf6 94%,#cddbf2 100%); /* IE10+ */
>-	filter: progid:DXImageTransform.Microsoft.gradient( startColorstr='#ffffff', endColorstr='#cddbf2',GradientType=0 ); /* IE6-9 */
>+    filter: progid:DXImageTransform.Microsoft.gradient( startColorstr='#eaeef5', endColorstr='#cddbf2',GradientType=0 ); /* IE6-9 */
> 	background: linear-gradient(top, #ffffff 0%,#f4f6fa 2%,#eaeef5 23%,#e8edf6 94%,#cddbf2 100%); /* W3C */
> 	border : 1px solid #bcbcbc;
> 	width : 55%;
>@@ -1584,7 +1583,6 @@ div.message {
> 	background: -webkit-linear-gradient(left, #eef4fe 0%,#eef4fe 88%,#f6f9fe 98%,#ffffff 99%,#a5c2f6 99%,#e6eefe 100%,#cbdefe 100%); /* Chrome10+,Safari5.1+ */
> 	background: -o-linear-gradient(left, #eef4fe 0%,#eef4fe 88%,#f6f9fe 98%,#ffffff 99%,#a5c2f6 99%,#e6eefe 100%,#cbdefe 100%); /* Opera11.10+ */
> 	background: -ms-linear-gradient(left, #eef4fe 0%,#eef4fe 88%,#f6f9fe 98%,#ffffff 99%,#a5c2f6 99%,#e6eefe 100%,#cbdefe 100%); /* IE10+ */
>-	filter: progid:DXImageTransform.Microsoft.gradient( startColorstr='#eef4fe', endColorstr='#cbdefe',GradientType=1 ); /* IE6-9 */
> 	background: linear-gradient(left, #eef4fe 0%,#eef4fe 88%,#f6f9fe 98%,#ffffff 99%,#a5c2f6 99%,#e6eefe 100%,#cbdefe 100%); /* W3C */
> 	border : 1px solid #739acf;
> 	padding : .3em 1em 0 0;
>@@ -1739,7 +1737,6 @@ div#menu li a {
> 	background: -o-linear-gradient(left, #eeeeee 0%,#eeeeee 96%,#e6e6e6 97%,#cccccc 99%,#c1c1c1 100%); /* Opera 11.10+ */
> 	background: -ms-linear-gradient(left, #eeeeee 0%,#eeeeee 96%,#e6e6e6 97%,#cccccc 99%,#c1c1c1 100%); /* IE10+ */
> 	background: linear-gradient(left, #eeeeee 0%,#eeeeee 96%,#e6e6e6 97%,#cccccc 99%,#c1c1c1 100%); /* W3C */
>-	filter: progid:DXImageTransform.Microsoft.gradient( startColorstr='#eeeeee', endColorstr='#c1c1c1',GradientType=1 ); /* IE6-9 */
> 	text-decoration : none;
> 	display : block;
> 	border : 1px solid #979797;
>@@ -1757,7 +1754,6 @@ div#menu li a:hover {
> 	background: -o-linear-gradient(left, #eaeef5 0%,#dee6f4 96%,#c4d5ef 98%,#a2bee8 100%); /* Opera 11.10+ */
> 	background: -ms-linear-gradient(left, #eaeef5 0%,#dee6f4 96%,#c4d5ef 98%,#a2bee8 100%); /* IE10+ */
> 	background: linear-gradient(left, #eaeef5 0%,#dee6f4 96%,#c4d5ef 98%,#a2bee8 100%); /* W3C */
>-	filter: progid:DXImageTransform.Microsoft.gradient( startColorstr='#eaeef5', endColorstr='#a2bee8',GradientType=1 ); /* IE6-9 */
> }
> 
> div#menu li.active a:hover {
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 7687: 13122 | 13336 | 13779