Bugzilla – Attachment 137794 Details for
Bug 27045
Exports using CSV profiles with tab as separator don't work correctly
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27045: (follow-up) Fix delimiter in header rows
Bug-27045-follow-up-Fix-delimiter-in-header-rows.patch (text/plain), 1.38 KB, created by
Katrin Fischer
on 2022-07-16 11:25:23 UTC
(
hide
)
Description:
Bug 27045: (follow-up) Fix delimiter in header rows
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2022-07-16 11:25:23 UTC
Size:
1.38 KB
patch
obsolete
>From 7db5998da22c561e310d741d370def85ab2fc4b1 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Sat, 16 Jul 2022 11:23:54 +0000 >Subject: [PATCH] Bug 27045: (follow-up) Fix delimiter in header rows > >The header rows still showed \t because the newly defined >variable wasn't used there. > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > C4/Acquisition.pm | 2 +- > serials/lateissues-export.pl | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm >index 830436bcaa..bf8a215573 100644 >--- a/C4/Acquisition.pm >+++ b/C4/Acquisition.pm >@@ -311,7 +311,7 @@ sub GetBasketAsCSV { > } > push @rows, \@row; > } >- my $content = join( $csv_profile->csv_separator, @headers ) . "\n"; >+ my $content = join( $delimiter, @headers ) . "\n"; > for my $row ( @rows ) { > $csv->combine(@$row); > my $string = $csv->string; >diff --git a/serials/lateissues-export.pl b/serials/lateissues-export.pl >index de09d4c58a..af83f2c6f6 100755 >--- a/serials/lateissues-export.pl >+++ b/serials/lateissues-export.pl >@@ -83,7 +83,7 @@ print $query->header( > -attachment => "serials-claims.csv", > ); > >-print join( $csv_profile->csv_separator, @headers ) . "\n"; >+print join( $delimiter, @headers ) . "\n"; > > for my $row ( @rows ) { > $csv->combine(@$row); >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27045
:
113890
|
113891
|
137790
|
137791
|
137792
|
137793
|
137794
|
137933
|
137934
|
137935