Attachment 137800 Details for Bug 20439 – Bug 20439: Sort SMS providers in alphabetical order by DB field

[patch] Bug 20439: Sort SMS providers in alphabetical order by DB field

Bug-20439-Sort-SMS-providers-in-alphabetical-order.patch (text/plain), 2.23 KB, created by Martin Renvoize (ashimema) on 2022-07-18 09:04:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2022-07-18 09:04:19 UTC

Size: 2.23 KB

patch

obsolete

>From f986f10560f0e453bcc28b496e64584ce2773417 Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Fri, 15 Jul 2022 16:55:53 +0000
>Subject: [PATCH] Bug 20439: Sort SMS providers in alphabetical order by DB
> field
>
>To test:
>1/ Add 'Email' to the 'SMSSendDriver' system preference.
>2/ Make sure 'EnhancedMessagingPreferencesOPAC' and 'EnhancedMessagingPreferences' are turned on.
>3/ Add some SMS providers (/cgi-bin/koha/admin/sms_providers.pl) with different names.
>4/ Notice on memberentry.pl and opac-messaging.pl the SMS providers sort by when they were added, not alphabetically.
>5/ Apply patch and restart services.
>6/ Look at memberentry.pl and opac-messaging.pl and notice that they SMS providers now sort alphabetically.
>
>Signed-off-by: George Williams <george@nekls.org
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> members/memberentry.pl | 2 +-
> opac/opac-messaging.pl | 6 ++++--
> 2 files changed, 5 insertions(+), 3 deletions(-)
>
>diff --git a/members/memberentry.pl b/members/memberentry.pl
>index d406817ecd..6a42ebd938 100755
>--- a/members/memberentry.pl
>+++ b/members/memberentry.pl
>@@ -68,7 +68,7 @@ if ( $borrowernumber and not $patron ) {
> }
> 
> if ( C4::Context->preference('SMSSendDriver') eq 'Email' ) {
>-    my @providers = Koha::SMS::Providers->search->as_list;
>+    my @providers = Koha::SMS::Providers->search( {}, { order_by => 'name' } )->as_list;
>     $template->param( sms_providers => \@providers );
> }
> 
>diff --git a/opac/opac-messaging.pl b/opac/opac-messaging.pl
>index 01faeb3cf4..a221b39a83 100755
>--- a/opac/opac-messaging.pl
>+++ b/opac/opac-messaging.pl
>@@ -79,8 +79,10 @@ $template->param(
>                   TalkingTechItivaPhone        =>  C4::Context->preference("TalkingTechItivaPhoneNotification") );
> 
> if ( C4::Context->preference("SMSSendDriver") eq 'Email' ) {
>-    my $providers = Koha::SMS::Providers->search;
>-    $template->param( sms_providers => $providers, sms_provider_id => $patron->sms_provider_id );
>+    my @providers = Koha::SMS::Providers->search( {}, { order_by => 'name' } )->as_list;
>+    $template->param(
>+            sms_providers => \@providers,
>+            sms_provider_id => $patron->sms_provider_id );
> }
> 
> my $new_session_id = $query->cookie('CGISESSID');
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 20439: 137579 | 137590 | 137786 | 137800