Attachment 137871 Details for Bug 25498 – Bug 25498: (follow-up) Change for autocomplete change of 30578

[patch] Bug 25498: (follow-up) Change for autocomplete change of 30578

Bug-25498-follow-up-Change-for-autocomplete-change.patch (text/plain), 2.31 KB, created by Jonathan Druart on 2022-07-19 12:59:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2022-07-19 12:59:19 UTC

Size: 2.31 KB

patch

obsolete

>From 7306a6f75f7cf1677d68c2ef0c97a19e55890de6 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Tue, 19 Jul 2022 12:18:21 +0000
>Subject: [PATCH] Bug 25498: (follow-up) Change for autocomplete change of
> 30578
>
>Test plan:
>Check if the patron search still works on the intranet shelves form
>when transferring ownership.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> .../prog/en/modules/virtualshelves/shelves.tt | 21 ++++++-------------
> 1 file changed, 6 insertions(+), 15 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
>index b08607e974b..356f801614f 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
>@@ -892,21 +892,12 @@
> 
>         [% IF op == 'transfer' %]
>             $(document).ready(function() {
>-                $('#find_patron').autocomplete({
>-                    source: "/cgi-bin/koha/circ/ysearch.pl",
>-                    minLength: 3,
>-                    select: function( event, ui ) {
>-                        $('#new_owner_name').html( ui.item.firstname + " " + ui.item.surname );
>-                        $('#new_owner').val( ui.item.borrowernumber );
>-                        $('#find_patron').val('').focus();
>-                        return false;
>-                    },
>-                }).data('ui-autocomplete')._renderItem = function( ul, item ) {
>-                    return $('<li></li>')
>-                        .data( 'ui-autocomplete-item', item )
>-                        .append( '<a>' + item.surname + ', ' + item.firstname + '</a>' )
>-                        .appendTo(ul);
>-                };
>+                patron_autocomplete( $("#find_patron"), { 'on-select-callback': function( event, ui ) {
>+                    $('#new_owner_name').html( ui.item.firstname + " " + ui.item.surname );
>+                    $('#new_owner').val( ui.item.patron_id );
>+                    $('#find_patron').val('').focus();
>+                    return false;
>+                }});
> 
>                 $('#transferform').submit(function() {
>                     if( $('#new_owner').val() == '' ) {
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 25498: 135889 | 135921 | 136008 | 136009 | 136010 | 136011 | 136033 | 136034 | 136035 | 136036 | 136166 | 136167 | 136168 | 136169 | 136220 | 136221 | 137862 | 137863 | 137864 | 137865 | 137866 | 137867 | 137871 | 137908