Bugzilla – Attachment 137934 Details for
Bug 27045
Exports using CSV profiles with tab as separator don't work correctly
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27045: Fix other exports using CSV profiles
Bug-27045-Fix-other-exports-using-CSV-profiles.patch (text/plain), 2.64 KB, created by
Nick Clemens (kidclamp)
on 2022-07-20 14:38:41 UTC
(
hide
)
Description:
Bug 27045: Fix other exports using CSV profiles
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2022-07-20 14:38:41 UTC
Size:
2.64 KB
patch
obsolete
>From 4b14009388d33906f6a5b78b9b988a84633fe133 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 20 Nov 2020 15:33:14 +0100 >Subject: [PATCH] Bug 27045: Fix other exports using CSV profiles > >This patch corrects the export of the 2 other reports >using CSV profiles: > >* Late issues (serials) >* Basket (acquisitions) > >To test: >1) Late issues >* Update the late issues sample report to use tab as separator >* Create a subscription >* Go to serial collection and 'generate next' to get some late issues >* Go to Claims >* Export the late issues and verify format is correct >* Verify exported file has tabs > >2) Basket summary >* Create an order with several order lines >* Create an SQL type CSV profile for basket export using tab as separator > Example: aqorders.quantity|aqordres.listprice|Title=biblio.title >* Export the basket using your configured CSV profile >* Verify exported file has tabs > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > C4/Acquisition.pm | 4 +++- > serials/lateissues-export.pl | 5 ++++- > 2 files changed, 7 insertions(+), 2 deletions(-) > >diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm >index 76b6e647c6..830436bcaa 100644 >--- a/C4/Acquisition.pm >+++ b/C4/Acquisition.pm >@@ -276,7 +276,9 @@ sub GetBasketAsCSV { > my $csv_profile = Koha::CsvProfiles->find( $csv_profile_id ); > Koha::Exceptions::ObjectNotFound->throw( 'There is no valid csv profile given') unless $csv_profile; > >- my $csv = Text::CSV_XS->new({'quote_char'=>'"','escape_char'=>'"','sep_char'=>$csv_profile->csv_separator,'binary'=>1}); >+ my $delimiter = $csv_profile->csv_separator; >+ $delimiter = "\t" if $delimiter eq "\\t"; >+ my $csv = Text::CSV_XS->new({'quote_char'=>'"','escape_char'=>'"','sep_char'=>$delimiter,'binary'=>1}); > my $csv_profile_content = $csv_profile->content; > my ( @headers, @fields ); > while ( $csv_profile_content =~ / >diff --git a/serials/lateissues-export.pl b/serials/lateissues-export.pl >index f20cdbe02c..de09d4c58a 100755 >--- a/serials/lateissues-export.pl >+++ b/serials/lateissues-export.pl >@@ -35,10 +35,13 @@ my $csv_profile_id = $query->param('csv_profile'); > my $csv_profile = Koha::CsvProfiles->find( $csv_profile_id ); > die "There is no valid csv profile given" unless $csv_profile; > >+my $delimiter = $csv_profile->csv_separator; >+$delimiter = "\t" if $delimiter eq "\\t"; >+ > my $csv = Text::CSV_XS->new({ > 'quote_char' => '"', > 'escape_char' => '"', >- 'sep_char' => $csv_profile->csv_separator, >+ 'sep_char' => $delimiter, > 'binary' => 1 > }); > >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27045
:
113890
|
113891
|
137790
|
137791
|
137792
|
137793
|
137794
|
137933
| 137934 |
137935