Attachment 137936 Details for Bug 31186 – Bug 31186: Fix the hidingrules test for result numbering

[patch] Bug 31186: Fix the hidingrules test for result numbering

Bug-31186-Fix-the-hidingrules-test-for-result-numb.patch (text/plain), 1.11 KB, created by Nick Clemens (kidclamp) on 2022-07-20 14:41:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2022-07-20 14:41:51 UTC

Size: 1.11 KB

patch

obsolete

>From 739d9833b458b882f6445f729846a20784d0a1e0 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Tue, 19 Jul 2022 11:27:55 +0000
>Subject: [PATCH] Bug 31186: Fix the hidingrules test for result numbering
>
>We should not test the $hidingrules variable but the number
>of keys it contains.
>
>Test plan:
>Clear OpacHiddenItems.
>Check with and without this patch search result numbering on
>the OPAC.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> opac/opac-search.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/opac/opac-search.pl b/opac/opac-search.pl
>index fb13bc5c56..e3b8ea0a2c 100755
>--- a/opac/opac-search.pl
>+++ b/opac/opac-search.pl
>@@ -759,7 +759,7 @@ for (my $i=0;$i<@servers;$i++) {
>                 $template->param(searchdesc => 1);
>             }
>             $template->param(results_per_page =>  $results_per_page);
>-            my $hide = ($hidingrules) ? 1 : 0;
>+            my $hide = keys %$hidingrules ? 1 : 0;
> 
>             $template->param(
>                 SEARCH_RESULTS => \@newresults,
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 31186: 137861 | 137936